approval: add docker restart/stop/kill to DANGEROUS_PATTERNS (#33438)

When docker.sock is mounted (common Docker Compose pattern), the agent
can restart/stop/kill containers without user approval. hermes gateway
restart is already protected, but docker restart, docker stop,
docker kill, and their docker compose equivalents were not.

This caused repeated self-termination: the agent ran docker restart
hermes, killed its own container, Docker restarted it (restart policy),
and the agent resumed the same session — creating a restart loop.

Added patterns mirror the existing gateway lifecycle protection:
- docker compose restart/stop/kill/down
- docker restart/stop/kill

Co-authored-by: Sarbai <sarbai@users.noreply.github.com>
This commit is contained in:
Брагарник Дмитро 2026-05-29 06:26:54 +03:00 committed by GitHub
parent 593e4b435e
commit 54bf798765
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -367,6 +367,13 @@ DANGEROUS_PATTERNS = [
# terminates all running agents mid-work.
(r'\bhermes\s+gateway\s+(stop|restart)\b', "stop/restart hermes gateway (kills running agents)"),
(r'\bhermes\s+update\b', "hermes update (restarts gateway, kills running agents)"),
# Docker container lifecycle — any user with docker.sock mounted (a common
# Docker Compose pattern) gives the agent the ability to restart/stop/kill
# containers without approval. These are agent-initiated lifecycle operations
# that should always require user consent, just like `hermes gateway restart`
# already does for the gateway process.
(r'\bdocker\s+compose\s+(restart|stop|kill|down)\b', "docker compose restart/stop/kill/down (container lifecycle)"),
(r'\bdocker\s+(restart|stop|kill)\b', "docker restart/stop/kill (container lifecycle)"),
# Gateway protection: never start gateway outside systemd management
(r'gateway\s+run\b.*(&\s*$|&\s*;|\bdisown\b|\bsetsid\b)', "start gateway outside systemd (use 'systemctl --user restart hermes-gateway')"),
(r'\bnohup\b.*gateway\s+run\b', "start gateway outside systemd (use 'systemctl --user restart hermes-gateway')"),