mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-13 14:02:16 +00:00
feat(docker): re-seed a terminally-dead Nous bootstrap session on boot (#59983)
The stage2-hook auth.json seed is first-boot-only ([ ! -f auth.json ]) to avoid clobbering rotated refresh tokens on restart. That guard means a container whose Nous bootstrap session took a terminal invalid_grant (tokens cleared, providers.nous.last_auth_error.relogin_required stamped) cannot recover from a restart — it stays unauthenticated until the credential is replaced. Add a self-heal path: an orchestrator that manages the container supplies a freshly-issued session via HERMES_AUTH_JSON_REBOOTSTRAP (distinct from the create-only *_BOOTSTRAP var). On boot, scripts/docker_rebootstrap_nous_session.py swaps ONLY the providers.nous entry, and ONLY when the on-disk entry is provably terminal (quarantine marker + no usable tokens). Healthy/rotating/absent/ unparseable auth.json is always a no-op, so the env is safe to leave set across restarts and never clobbers a good token. Pure stdlib, runs as its own subprocess, always exits 0 so a re-seed error never fails the boot. Reuses the same terminal predicate as get_nous_session_validity() so we re-seed only a session that is genuinely dead.
This commit is contained in:
parent
586aae4bf1
commit
536ffedbf4
3 changed files with 336 additions and 0 deletions
140
tests/tools/test_docker_rebootstrap_nous_session.py
Normal file
140
tests/tools/test_docker_rebootstrap_nous_session.py
Normal file
|
|
@ -0,0 +1,140 @@
|
|||
"""Unit tests for scripts/docker_rebootstrap_nous_session.py.
|
||||
|
||||
The boot-time re-seed is the load-bearing "does not clobber a healthy session"
|
||||
guard: it must overwrite the on-disk Nous provider entry ONLY when that entry is
|
||||
provably terminal (quarantine marker + no usable tokens), and no-op in every
|
||||
other case. These are pure-stdlib tmp_path tests (no container build).
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import importlib.util
|
||||
import json
|
||||
from pathlib import Path
|
||||
|
||||
# Import the stdlib-only boot helper by path (it lives under scripts/, not an
|
||||
# installed package) — mirrors the repo's other scripts/-helper tests.
|
||||
_SCRIPT = Path(__file__).resolve().parents[2] / "scripts" / "docker_rebootstrap_nous_session.py"
|
||||
_spec = importlib.util.spec_from_file_location("docker_rebootstrap_nous_session", _SCRIPT)
|
||||
mod = importlib.util.module_from_spec(_spec)
|
||||
_spec.loader.exec_module(mod)
|
||||
|
||||
|
||||
def _terminal_nous_state():
|
||||
"""On-disk shape after a terminal quarantine: tokens cleared, marker set."""
|
||||
return {
|
||||
"portal_base_url": "https://portal.example.com",
|
||||
"client_id": "hermes-cli-vps",
|
||||
"last_auth_error": {
|
||||
"provider": "nous",
|
||||
"code": "invalid_grant",
|
||||
"relogin_required": True,
|
||||
},
|
||||
}
|
||||
|
||||
|
||||
def _healthy_nous_state():
|
||||
return {
|
||||
"portal_base_url": "https://portal.example.com",
|
||||
"client_id": "hermes-cli-vps",
|
||||
"access_token": "live-at",
|
||||
"refresh_token": "live-rt",
|
||||
}
|
||||
|
||||
|
||||
def _write_auth(tmp_path: Path, providers: dict) -> str:
|
||||
p = tmp_path / "auth.json"
|
||||
p.write_text(json.dumps({"version": 1, "providers": providers}))
|
||||
return str(p)
|
||||
|
||||
|
||||
_FRESH_SEED = json.dumps({
|
||||
"version": 1,
|
||||
"providers": {
|
||||
"nous": {
|
||||
"portal_base_url": "https://portal.example.com",
|
||||
"client_id": "hermes-cli-vps",
|
||||
"access_token": "FRESH-at",
|
||||
"refresh_token": "FRESH-rt",
|
||||
}
|
||||
},
|
||||
})
|
||||
|
||||
|
||||
def test_reseeds_terminal_entry(tmp_path):
|
||||
"""Terminal on-disk entry + valid seed → providers.nous replaced."""
|
||||
auth = _write_auth(tmp_path, {"nous": _terminal_nous_state()})
|
||||
result = mod.reseed_if_terminal(auth, _FRESH_SEED)
|
||||
assert result == "reseeded"
|
||||
store = json.loads(Path(auth).read_text())
|
||||
assert store["providers"]["nous"]["refresh_token"] == "FRESH-rt"
|
||||
assert "last_auth_error" not in store["providers"]["nous"]
|
||||
|
||||
|
||||
def test_does_not_clobber_healthy_entry(tmp_path):
|
||||
"""LOAD-BEARING: a healthy (live-token) entry must never be overwritten."""
|
||||
auth = _write_auth(tmp_path, {"nous": _healthy_nous_state()})
|
||||
result = mod.reseed_if_terminal(auth, _FRESH_SEED)
|
||||
assert result == "not_terminal"
|
||||
store = json.loads(Path(auth).read_text())
|
||||
# Untouched — still the live tokens, not the seed.
|
||||
assert store["providers"]["nous"]["refresh_token"] == "live-rt"
|
||||
|
||||
|
||||
def test_marker_but_live_token_is_not_terminal(tmp_path):
|
||||
"""Stale marker + a live token present → NOT terminal (don't clobber)."""
|
||||
state = _terminal_nous_state()
|
||||
state["refresh_token"] = "somehow-live"
|
||||
auth = _write_auth(tmp_path, {"nous": state})
|
||||
assert mod.reseed_if_terminal(auth, _FRESH_SEED) == "not_terminal"
|
||||
|
||||
|
||||
def test_preserves_other_providers(tmp_path):
|
||||
"""Re-seed swaps ONLY providers.nous; other providers survive intact."""
|
||||
auth = _write_auth(tmp_path, {
|
||||
"nous": _terminal_nous_state(),
|
||||
"openai-codex": {"tokens": {"access_token": "codex-at"}},
|
||||
})
|
||||
assert mod.reseed_if_terminal(auth, _FRESH_SEED) == "reseeded"
|
||||
store = json.loads(Path(auth).read_text())
|
||||
assert store["providers"]["openai-codex"]["tokens"]["access_token"] == "codex-at"
|
||||
assert store["providers"]["nous"]["refresh_token"] == "FRESH-rt"
|
||||
|
||||
|
||||
def test_no_seed_is_noop(tmp_path):
|
||||
auth = _write_auth(tmp_path, {"nous": _terminal_nous_state()})
|
||||
assert mod.reseed_if_terminal(auth, "") == "no_seed"
|
||||
|
||||
|
||||
def test_bad_seed_is_noop(tmp_path):
|
||||
auth = _write_auth(tmp_path, {"nous": _terminal_nous_state()})
|
||||
assert mod.reseed_if_terminal(auth, "}{not json") == "bad_seed"
|
||||
# Original terminal entry left untouched.
|
||||
store = json.loads(Path(auth).read_text())
|
||||
assert store["providers"]["nous"]["last_auth_error"]["relogin_required"] is True
|
||||
|
||||
|
||||
def test_seed_without_nous_entry_is_noop(tmp_path):
|
||||
auth = _write_auth(tmp_path, {"nous": _terminal_nous_state()})
|
||||
seed = json.dumps({"version": 1, "providers": {"openai-codex": {}}})
|
||||
assert mod.reseed_if_terminal(auth, seed) == "bad_seed"
|
||||
|
||||
|
||||
def test_absent_auth_file_defers_to_bootstrap(tmp_path):
|
||||
"""No auth.json → blank volume; the normal *_BOOTSTRAP path handles it."""
|
||||
auth = str(tmp_path / "auth.json")
|
||||
assert mod.reseed_if_terminal(auth, _FRESH_SEED) == "no_auth_file"
|
||||
|
||||
|
||||
def test_unreadable_auth_file_is_left_alone(tmp_path):
|
||||
p = tmp_path / "auth.json"
|
||||
p.write_text("}{ corrupt")
|
||||
assert mod.reseed_if_terminal(str(p), _FRESH_SEED) == "auth_unreadable"
|
||||
# Not overwritten.
|
||||
assert p.read_text() == "}{ corrupt"
|
||||
|
||||
|
||||
def test_terminal_entry_missing_marker_is_not_terminal(tmp_path):
|
||||
"""No last_auth_error at all (e.g. a merely-expired but not-quarantined
|
||||
entry) → not terminal, no re-seed."""
|
||||
auth = _write_auth(tmp_path, {"nous": {"client_id": "hermes-cli-vps"}})
|
||||
assert mod.reseed_if_terminal(auth, _FRESH_SEED) == "not_terminal"
|
||||
Loading…
Add table
Add a link
Reference in a new issue