From 50158a60f941868a6fd57e5c9f86da886ab38e1e Mon Sep 17 00:00:00 2001 From: houenyang-momo <259054917+houenyang-momo@users.noreply.github.com> Date: Mon, 18 May 2026 20:05:17 -0700 Subject: [PATCH] fix(tui): improve charizard completion menu contrast --- hermes_cli/skin_engine.py | 7 ++++++- tests/hermes_cli/test_skin_engine.py | 12 ++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/hermes_cli/skin_engine.py b/hermes_cli/skin_engine.py index 0946eae9168..18d92cdd6e7 100644 --- a/hermes_cli/skin_engine.py +++ b/hermes_cli/skin_engine.py @@ -572,7 +572,7 @@ _BUILTIN_SKINS: Dict[str, Dict[str, Any]] = { "banner_border": "#C75B1D", "banner_title": "#FFD39A", "banner_accent": "#F29C38", - "banner_dim": "#7A3511", + "banner_dim": "#C58A45", "banner_text": "#FFF0D4", "ui_accent": "#F29C38", "ui_label": "#FFD39A", @@ -592,6 +592,11 @@ _BUILTIN_SKINS: Dict[str, Dict[str, Any]] = { "status_bar_critical": "#EF5350", "session_label": "#FFD39A", "session_border": "#6C4724", + "selection_bg": "#5A260D", + "completion_menu_bg": "#0B0503", + "completion_menu_current_bg": "#4A1B07", + "completion_menu_meta_bg": "#120806", + "completion_menu_meta_current_bg": "#5A260D", }, "spinner": { "waiting_faces": ["(✦)", "(▲)", "(◇)", "(<>)", "(🔥)"], diff --git a/tests/hermes_cli/test_skin_engine.py b/tests/hermes_cli/test_skin_engine.py index 1ed7e35323b..0de68b5150b 100644 --- a/tests/hermes_cli/test_skin_engine.py +++ b/tests/hermes_cli/test_skin_engine.py @@ -100,6 +100,18 @@ class TestBuiltinSkins: assert skin.get_color("banner_text") == "#2C1810" assert skin.get_color("completion_menu_bg") == "#F5EFE0" + def test_charizard_skin_has_dark_ember_completion_menu(self): + from hermes_cli.skin_engine import load_skin + + skin = load_skin("charizard") + assert skin.name == "charizard" + assert skin.get_color("banner_dim") == "#C58A45" + assert skin.get_color("completion_menu_bg") == "#0B0503" + assert skin.get_color("completion_menu_current_bg") == "#4A1B07" + assert skin.get_color("completion_menu_meta_bg") == "#120806" + assert skin.get_color("completion_menu_meta_current_bg") == "#5A260D" + assert skin.get_color("selection_bg") == "#5A260D" + def test_unknown_skin_falls_back_to_default(self): from hermes_cli.skin_engine import load_skin skin = load_skin("nonexistent_skin_xyz")