mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-13 03:52:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

fix(mcp): give 'mcp add --command' a distinct argparse dest

Browse source 
The --command flag of `hermes mcp add` shared its argparse dest with the
top-level subparser (`dest="command"` in `hermes_cli/_parser.py`). When
the flag was omitted, argparse still wrote `args.command = None`,
clobbering the top-level value of `"mcp"`. The dispatcher then saw
`args.command is None` and fell through to interactive chat, so
`hermes mcp add ...` silently launched chat instead of registering the
server. `cmd_mcp_add` was never reached.

Use `dest="mcp_command"` on the flag and read it from `cmd_mcp_add`.
The user-facing CLI flag `--command` is unchanged; only the in-memory
namespace attribute moves. Also updates the `_make_args` helper in
`tests/hermes_cli/test_mcp_config.py` to populate the new dest, and
adds `tests/hermes_cli/test_mcp_add_command_dest.py` with a parser-
level regression test.

Closes #19785.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
badfriend 2026-05-04 21:28:13 +07:00 • committed by Teknium
parent 333598cb0e
commit 4f364c4e99
4 changed files with 105 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/hermes_cli/test_mcp_config.py
View file

@ -43,7 +43,7 @@ def _make_args(**kwargs):
defaults = {
"name": "test-server",
"url": None,
"command": None,
"mcp_command": None,
"args": None,
"auth": None,
"preset": None,
@ -233,7 +233,7 @@ class TestMcpAdd:
cmd_mcp_add(_make_args(
name="github",
command="npx",
mcp_command="npx",
args=["@mcp/github"],
))
out = capsys.readouterr().out
@ -291,7 +291,7 @@ class TestMcpAdd:
cmd_mcp_add(_make_args(
name="github",
command="npx",
mcp_command="npx",
args=["@mcp/github"],
env=["MY_API_KEY=secret123", "DEBUG=true"],
))
@ -313,7 +313,7 @@ class TestMcpAdd:
cmd_mcp_add(_make_args(
name="github",
command="npx",
mcp_command="npx",
args=["@mcp/github"],
env=["BAD-NAME=value"],
))
@ -390,7 +390,7 @@ class TestMcpAdd:
cmd_mcp_add(_make_args(
name="custom",
preset="testmcp",
command="uvx",
mcp_command="uvx",
args=["custom-server"],
))
out = capsys.readouterr().out