mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-24 16:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(compress): type-pin the lock-skip signal check at every consumer

Browse source 
The bare truthiness test on _compression_skipped_due_to_lock is fooled
by MagicMock auto-attributes on test-double agents (skill pitfall:
MagicMock defeats hasattr/truthiness duck-typing) — the type-ahead CLI
test's MagicMock agent took the lock-skip branch and skipped the
transcript commit. Real values are None/True/holder-string; pin the
check to 'is True or isinstance(str)' at all three consumer sites.
This commit is contained in:
Teknium 2026-07-23 08:08:06 -07:00
parent eb7be2edde
commit 4cb85fb7fc
3 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
cli.py
View file

@ -10183,7 +10183,14 @@ class HermesCLI(CLIAgentSetupMixin, CLICommandsMixin, CLIBillingMixin):
# "No changes from compression" no-op text. The wording
# distinguishes a confirmed holder from an unconfirmed
# acquisition failure (describe_compression_lock_skip).
if getattr(self.agent, "_compression_skipped_due_to_lock", None):
# Type-pinned check (is True / str): the flag's only real
# values are None/True/holder-string, and a bare getattr
# truthiness test is fooled by MagicMock auto-attributes on
# test-double agents (skill pitfall: MagicMock vs hasattr).
_lock_skip_signal = getattr(
self.agent, "_compression_skipped_due_to_lock", None
)
if _lock_skip_signal is True or isinstance(_lock_skip_signal, str):
from agent.manual_compression_feedback import (
describe_compression_lock_skip,
)

2
gateway/slash_commands.py
View file

@ -3573,7 +3573,7 @@ class GatewaySlashCommandsMixin:
# The deferred context-engine notification is discarded by
# the finally block below (finalize committed=False).
_lock_skipped = getattr(tmp_agent, "_compression_skipped_due_to_lock", None)
if _lock_skipped:
if _lock_skipped is True or isinstance(_lock_skipped, str):
from agent.manual_compression_feedback import (
describe_compression_lock_skip,
)

4
tui_gateway/server.py
View file

@ -3745,8 +3745,10 @@ def _compress_session_history(
# If _compress_context returned unchanged because a concurrent
# compression lock is held, raise so callers can surface a clear
# message instead of the misleading "No changes from compression" text.
# Type-pinned (is True / str): real values are None/True/holder-string;
# bare truthiness is fooled by MagicMock auto-attrs on test doubles.
_lock_skipped = getattr(agent, "_compression_skipped_due_to_lock", None)
if _lock_skipped:
if _lock_skipped is True or isinstance(_lock_skipped, str):
agent._compression_skipped_due_to_lock = None
# No boundary was committed on a lock-skip; discard any pending
# deferred context-engine notification (exactly-once, no-op safe).