mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-06 02:41:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

review(copilot): clarify table-rule rationale (UTF-16 code units, not graphemes)

Browse source
This commit is contained in:
Brooklyn Nicholson 2026-04-28 15:29:11 -05:00
parent 9eabc24e24
commit 4689ace7cb
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
ui-tui/src/components/markdown.tsx
View file

@ -99,10 +99,11 @@ const renderTable = (k: number, rows: string[][], t: Theme) => {
// Thin divider under the header. Without it tables look like prose
// with extra spacing because the header is just amber-coloured text
// (#15534). We avoid full borders on purpose — column widths are
// grapheme-approximate so a real outline often misaligns; one dim
// dashed rule under row 0 plus tab-style column gaps reads cleanly
// on every terminal we tested.
// (#15534). We avoid full borders on purpose — column widths come
// from `stripInlineMarkup(...).length` (UTF-16 code units, not
// display width), so a real outline often misaligns on emoji and
// East-Asian wide characters; one dim dashed rule under row 0 plus
// tab-style column gaps reads cleanly on every terminal we tested.
const sep = widths.map(w => '─'.repeat(Math.max(1, w))).join(' ')
return (