mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-18 04:41:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(codex-spark): defensive 128k entry in DEFAULT_CONTEXT_LENGTHS + clarify validation test docstring

Browse source 
Two follow-ups from self-review:

1. Add gpt-5.3-codex-spark to DEFAULT_CONTEXT_LENGTHS at 128k. The
   primary resolution path for Spark goes through provider='openai-codex'
   → _CODEX_OAUTH_CONTEXT_FALLBACK (already correct). But if any future
   code path resolves Spark's context with a different provider (custom
   proxy, generic fallthrough), the longest-substring-first lookup in
   step 8 would match 'gpt-5' and report 400k, which is wrong by ~3x.
   Adding the explicit override is a cheap defensive correctness fix
   matching how gpt-5.4-mini and gpt-5.4-nano already shadow the generic
   gpt-5 entry.

2. Update test_openai_codex_model_validation_fallback.py docstring. The
   bug it was originally written for (gpt-5.3-codex-spark missing from
   listing) is now resolved by this PR's catalog restoration. The test
   still validly exercises the soft-accept code path for any future
   entitlement-gated Codex slug that ships before Hermes catalogs it,
   but the framing was stale — clarified.
This commit is contained in:
kshitijk4poor 2026-05-10 11:44:11 +05:30 • committed by kshitij
parent 826e7171e9
commit 44cdf555a8
2 changed files with 19 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
agent/model_metadata.py
View file

@ -157,6 +157,13 @@ DEFAULT_CONTEXT_LENGTHS = {
"gpt-5.4-nano": 400000, # 400k (not 1.05M like full 5.4)
"gpt-5.4-mini": 400000, # 400k (not 1.05M like full 5.4)
"gpt-5.4": 1050000, # GPT-5.4, GPT-5.4 Pro (1.05M context)
# gpt-5.3-codex-spark is Codex-OAuth-only (ChatGPT Pro entitlement) and
# uses a smaller 128k window than other gpt-5.x slugs. Listed here as
# a defensive override so the longest-substring fallback doesn't match
# the generic "gpt-5" entry below (400k) and report the wrong limit if
# Spark's context ever needs to be resolved through this path. Real
# usage flows through _CODEX_OAUTH_CONTEXT_FALLBACK at line ~1113.
"gpt-5.3-codex-spark": 128000,
"gpt-5.1-chat": 128000, # Chat variant has 128k context
"gpt-5": 400000, # GPT-5.x base, mini, codex variants (400k)
"gpt-4.1": 1047576,