From 3f013d289cc0b6b568aede11b98f17f18e2b2812 Mon Sep 17 00:00:00 2001 From: Brooklyn Nicholson Date: Mon, 11 May 2026 17:14:33 -0400 Subject: [PATCH] fix(process-registry): suppress windows-footgun false positive on guarded killpg Keep the existing POSIX-only process-group teardown path, but make the signal selection explicit via getattr and add an inline windows-footgun suppression marker on the guarded os.killpg line so the Windows footgun check no longer blocks CI on this intentionally platform-gated code. --- tools/process_registry.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/process_registry.py b/tools/process_registry.py index 8bbe1f56b7c..5efebd98d19 100644 --- a/tools/process_registry.py +++ b/tools/process_registry.py @@ -585,7 +585,8 @@ class ProcessRegistry: try: if not _IS_WINDOWS: try: - os.killpg(os.getpgid(proc.pid), signal.SIGKILL) + kill_signal = getattr(signal, "SIGKILL", signal.SIGTERM) + os.killpg(os.getpgid(proc.pid), kill_signal) # windows-footgun: ok - guarded by _IS_WINDOWS above except (ProcessLookupError, PermissionError, OSError): proc.kill() else: