mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-31 19:16:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(test): patch _launch_configured_cwd in completion tests for hermeticity (#70041)

Browse source 
tui_gateway/server.py freezes _hermes_home at import time, so
_launch_configured_cwd() reads the developer's real config.yaml even
under the per-test HERMES_HOME redirect. Any absolute terminal.cwd in
the real config made _completion_cwd() ignore monkeypatch.chdir and
broke the completion tests on a pristine checkout.

Patch _launch_configured_cwd to None in the autouse _reset_fuzzy_cache
fixture and add a regression test pinning that _completion_cwd resolves
via os.getcwd() under tests.

Salvaged from PR #70148 by @smfworks (rebased onto the pruned suite).
This commit is contained in:
Jasmine Naderi 2026-07-29 17:52:52 -07:00 • committed by Teknium
parent 66c4c9c0b1
commit 3e54a366e7
1 changed files with 31 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

31
tests/gateway/test_complete_path_at_filter.py
View file

@ -44,6 +44,14 @@ def _reset_fuzzy_cache(monkeypatch):
# Each test walks a fresh tmp dir; clear the cached listing so prior
# roots can't leak through the TTL window.
server._fuzzy_cache.clear()
# #70041: _launch_configured_cwd() reads the launch profile's config.yaml
# via _load_cfg(), which resolves through _hermes_home captured at module
# import time — before the per-test HERMES_HOME redirect applies. When the
# developer's real config sets terminal.cwd, _completion_cwd() returns that
# directory instead of the test's tmp_path (from monkeypatch.chdir). Patch
# it to None so _completion_cwd falls through to os.getcwd(), which
# monkeypatch.chdir controls.
monkeypatch.setattr(server, "_launch_configured_cwd", lambda: None)
yield
server._fuzzy_cache.clear()
@ -232,3 +240,26 @@ def test_leading_slash_prefers_a_real_absolute_path(tmp_path, monkeypatch):
assert not any("decoy.conf" in t for t in texts), texts
def test_completion_ignores_real_terminal_cwd(tmp_path, monkeypatch):
"""#70041: _completion_cwd must not read the developer's real config.yaml
terminal.cwd when running under hermetic tests.
The autouse _reset_fuzzy_cache fixture patches _launch_configured_cwd
to None so _completion_cwd falls through to os.getcwd() (controlled
by monkeypatch.chdir). This test verifies the fixture holds: with the
patch in place, a configured terminal.cwd from the launch profile's
real config can never leak into completion resolution.
"""
_fixture(tmp_path)
monkeypatch.chdir(tmp_path)
monkeypatch.delenv("TERMINAL_CWD", raising=False)
# _completion_cwd should resolve to tmp_path (via os.getcwd),
# not to any configured terminal.cwd from the real config.
resolved = server._completion_cwd({})
assert resolved == str(tmp_path), (
f"_completion_cwd resolved to {resolved} instead of {tmp_path} — "
f"the autouse fixture may not be patching _launch_configured_cwd"
)