mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-26 01:01:40 +00:00
feat: shell hooks — wire shell scripts as Hermes hook callbacks
Users can declare shell scripts in config.yaml under a hooks: block that fire on plugin-hook events (pre_tool_call, post_tool_call, pre_llm_call, subagent_stop, etc). Scripts receive JSON on stdin, can return JSON on stdout to block tool calls or inject context pre-LLM. Key design: - Registers closures on existing PluginManager._hooks dict — zero changes to invoke_hook() call sites - subprocess.run(shell=False) via shlex.split — no shell injection - First-use consent per (event, command) pair, persisted to allowlist JSON - Bypass via --accept-hooks, HERMES_ACCEPT_HOOKS=1, or hooks_auto_accept - hermes hooks list/test/revoke/doctor CLI subcommands - Adds subagent_stop hook event fired after delegate_task children exit - Claude Code compatible response shapes accepted Cherry-picked from PR #13143 by @pefontana.
This commit is contained in:
parent
34c5c2538e
commit
3988c3c245
14 changed files with 3241 additions and 9 deletions
|
|
@ -91,3 +91,42 @@ class TestYoloEnvVar:
|
|||
args = parser.parse_args(["chat"])
|
||||
self._simulate_cmd_chat_yolo_check(args)
|
||||
assert os.environ.get("HERMES_YOLO_MODE") is None
|
||||
|
||||
|
||||
class TestAcceptHooksOnAgentSubparsers:
|
||||
"""Verify --accept-hooks is accepted at every agent-subcommand
|
||||
position (before the subcommand, between group/subcommand, and
|
||||
after the leaf subcommand) for gateway/cron/mcp/acp. Regression
|
||||
against prior behaviour where the flag only worked on the root
|
||||
parser and `chat`, so `hermes gateway run --accept-hooks` failed
|
||||
with `unrecognized arguments`."""
|
||||
|
||||
@pytest.mark.parametrize("argv", [
|
||||
["--accept-hooks", "gateway", "run", "--help"],
|
||||
["gateway", "--accept-hooks", "run", "--help"],
|
||||
["gateway", "run", "--accept-hooks", "--help"],
|
||||
["--accept-hooks", "cron", "tick", "--help"],
|
||||
["cron", "--accept-hooks", "tick", "--help"],
|
||||
["cron", "tick", "--accept-hooks", "--help"],
|
||||
["cron", "run", "--accept-hooks", "dummy-id", "--help"],
|
||||
["--accept-hooks", "mcp", "serve", "--help"],
|
||||
["mcp", "--accept-hooks", "serve", "--help"],
|
||||
["mcp", "serve", "--accept-hooks", "--help"],
|
||||
["acp", "--accept-hooks", "--help"],
|
||||
])
|
||||
def test_accepted_at_every_position(self, argv):
|
||||
"""Invoking `hermes <argv>` must exit 0 (help) rather than
|
||||
failing with `unrecognized arguments`."""
|
||||
import subprocess
|
||||
result = subprocess.run(
|
||||
[sys.executable, "-m", "hermes_cli.main", *argv],
|
||||
capture_output=True,
|
||||
text=True,
|
||||
timeout=15,
|
||||
)
|
||||
assert result.returncode == 0, (
|
||||
f"argv={argv!r} returned {result.returncode}\n"
|
||||
f"stdout: {result.stdout[:300]}\n"
|
||||
f"stderr: {result.stderr[:300]}"
|
||||
)
|
||||
assert "unrecognized arguments" not in result.stderr
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue