refactor(tui): /clean pass across ui-tui — 49 files, −217 LOC

Full codebase pass using the /clean doctrine (KISS/DRY, no one-off
helpers, no variables-used-once, pure functional where natural,
inlined obvious one-liners, killed dead exports, narrowed types,
spaced JSX). All contracts preserved — no RPC method, event name,
or exported type shape changed.

app/ — 15 files, -134 LOC
- inlined 4 one-off helpers (titleCase, isLong, statusToneFrom,
  focusOutside predicate)
- stores to arrow-const style (buildUiState, buildTurnState,
  buildOverlayState plus get/patch/reset triplets)
- functional slash/registry byName map (flatMap over for-loops)
- dropped dead param `live` in cancelOverlayFromCtrlC
- DRY'd duplicate shift() call in scrollWithSelection
- consolidated sections.push calls in /help

components/ — 12 files, -40 LOC
- extracted inline prop types to interfaces at file bottom (13×)
- inlined 6 one-off vars (pctLabel, logoW, heroW, cwd, title, hint)
- promoted HEART_COLORS + OPTS/LABELS to module scope
- JSX sibling spacing across 9 files
- un-shadowed `raw` in textInput
- components/thinking.tsx + components/markdown.tsx untouched
  (structurally load-bearing / edge-case-heavy)

config content domain protocol/ — 8 files, -77 LOC
- tightened 3 regexes (MOUSE_TRACKING, looksLikeSlashCommand,
  hasInterpolation — dropped stateful lastIndex dance)
- dead export ParsedSlashCommand removed
- MODES narrowed to `as const`, `.find(m => m === s)` replaces
  `.includes() ? (as cast) : null`
- fortunes.ts hash via reduce
- fmtDuration ternary chain
- inlined aboveViewport predicate in viewport.ts

hooks/ + lib/ — 9 files, -38 LOC
- ANSI_RE via String.fromCharCode(27) + WS_RE lifted to module
  scope (no more eslint-disable no-control-regex)
- compactPreview/edgePreview/thinkingPreview → ternary arrows
- useCompletion: hoisted pathReplace, moved stale-ref guard earlier
- useInputHistory: dropped useCallback wrapper (append is stable)
- useVirtualHistory: replaced 4× any with unknown + narrow
  MeasuredNode interface + one cast site

root TS — 3 files, -63 LOC
- banner.ts: parseRichMarkup via matchAll instead of exec/lastIndex,
  artWidth via reduce
- gatewayClient.ts: resolvePython candidate list collapse, inlined
  one-branch guards in dispatch/pushLog/drain/request
- types.ts: alpha-sorted ActiveTool / Msg / SudoReq / SecretReq
  members

eslint config
- disabled react-hooks/exhaustive-deps on packages/hermes-ink/**
  (compiled by react/compiler, deps live in $[N] memo arrays that
  eslint can't introspect) and removed the now-orphan in-file
  disable directive in ScrollBox.tsx

fixes (not from the cleaner pass)
- useComposerState: unlinkSync(file) + try/catch → rmSync(file,
  { force: true }) — kills the no-empty lint error and is more
  idiomatic
- useConfigSync: added setBellOnComplete + setVoiceEnabled to the
  two useEffect dep arrays (they're stable React setState setters;
  adding is safe and silences exhaustive-deps)

verification
- npx eslint src/ packages/ → 0 errors, 0 warnings
- npm run type-check → clean
- npm test → 50/50
- npm run build → 394.8kb ink-bundle.js, 11ms esbuild
- pytest tests/tui_gateway/ tests/test_tui_gateway_server.py
  tests/hermes_cli/test_tui_resume_flow.py
  tests/hermes_cli/test_tui_npm_install.py → 57/57

ui-tui/src/domain/messages.ts

@@ -2,30 +2,17 @@ import { LONG_MSG } from '../config/limits.js'
 import { buildToolTrailLine, fmtK } from '../lib/text.js'
 import type { Msg, SessionInfo } from '../types.js'
 
-interface ImageMeta {
-  height?: number
-  token_estimate?: number
-  width?: number
-}
-
-interface TranscriptRow {
-  context?: string
-  name?: string
-  role?: string
-  text?: string
-}
-
 export const introMsg = (info: SessionInfo): Msg => ({ info, kind: 'intro', role: 'system', text: '' })
 
-export const imageTokenMeta = (info: ImageMeta | null | undefined) =>
-  [
-    info?.width && info.height ? `${info.width}x${info.height}` : '',
-    typeof info?.token_estimate === 'number' && info.token_estimate > 0 ? `~${fmtK(info.token_estimate)} tok` : ''
-  ]
+export const imageTokenMeta = (info?: ImageMeta | null) => {
+  const { width, height, token_estimate: t } = info ?? {}
+
+  return [width && height ? `${width}x${height}` : '', (t ?? 0) > 0 ? `~${fmtK(t!)} tok` : '']
     .filter(Boolean)
     .join(' · ')
+}
 
-export const userDisplay = (text: string): string => {
+export const userDisplay = (text: string) => {
   if (text.length <= LONG_MSG) {
     return text
   }
@@ -42,8 +29,8 @@ export const toTranscriptMessages = (rows: unknown): Msg[] => {
     return []
   }
 
-  const result: Msg[] = []
-  let pendingTools: string[] = []
+  const out: Msg[] = []
+  let pending: string[] = []
 
   for (const row of rows) {
     if (!row || typeof row !== 'object') {
@@ -53,7 +40,7 @@ export const toTranscriptMessages = (rows: unknown): Msg[] => {
     const { context, name, role, text } = row as TranscriptRow
 
     if (role === 'tool') {
-      pendingTools.push(buildToolTrailLine(name ?? 'tool', context ?? ''))
+      pending.push(buildToolTrailLine(name ?? 'tool', context ?? ''))
 
       continue
     }
@@ -63,40 +50,35 @@ export const toTranscriptMessages = (rows: unknown): Msg[] => {
     }
 
     if (role === 'assistant') {
-      const msg: Msg = { role, text }
-
-      if (pendingTools.length) {
-        msg.tools = pendingTools
-        pendingTools = []
-      }
-
-      result.push(msg)
-
-      continue
-    }
-
-    if (role === 'user' || role === 'system') {
-      pendingTools = []
-      result.push({ role, text })
+      out.push({ role, text, ...(pending.length && { tools: pending }) })
+      pending = []
+    } else if (role === 'user' || role === 'system') {
+      out.push({ role, text })
+      pending = []
     }
   }
 
-  return result
+  return out
 }
 
-export function fmtDuration(ms: number) {
-  const total = Math.max(0, Math.floor(ms / 1000))
-  const hours = Math.floor(total / 3600)
-  const mins = Math.floor((total % 3600) / 60)
-  const secs = total % 60
+export const fmtDuration = (ms: number) => {
+  const t = Math.max(0, Math.floor(ms / 1000))
+  const h = Math.floor(t / 3600)
+  const m = Math.floor((t % 3600) / 60)
+  const s = t % 60
 
-  if (hours > 0) {
-    return `${hours}h ${mins}m`
-  }
-
-  if (mins > 0) {
-    return `${mins}m ${secs}s`
-  }
-
-  return `${secs}s`
+  return h > 0 ? `${h}h ${m}m` : m > 0 ? `${m}m ${s}s` : `${s}s`
+}
+
+interface ImageMeta {
+  height?: number
+  token_estimate?: number
+  width?: number
+}
+
+interface TranscriptRow {
+  context?: string
+  name?: string
+  role?: string
+  text?: string
 }