refactor(tui): /clean pass across ui-tui — 49 files, −217 LOC

Full codebase pass using the /clean doctrine (KISS/DRY, no one-off
helpers, no variables-used-once, pure functional where natural,
inlined obvious one-liners, killed dead exports, narrowed types,
spaced JSX). All contracts preserved — no RPC method, event name,
or exported type shape changed.

app/ — 15 files, -134 LOC
- inlined 4 one-off helpers (titleCase, isLong, statusToneFrom,
  focusOutside predicate)
- stores to arrow-const style (buildUiState, buildTurnState,
  buildOverlayState plus get/patch/reset triplets)
- functional slash/registry byName map (flatMap over for-loops)
- dropped dead param `live` in cancelOverlayFromCtrlC
- DRY'd duplicate shift() call in scrollWithSelection
- consolidated sections.push calls in /help

components/ — 12 files, -40 LOC
- extracted inline prop types to interfaces at file bottom (13×)
- inlined 6 one-off vars (pctLabel, logoW, heroW, cwd, title, hint)
- promoted HEART_COLORS + OPTS/LABELS to module scope
- JSX sibling spacing across 9 files
- un-shadowed `raw` in textInput
- components/thinking.tsx + components/markdown.tsx untouched
  (structurally load-bearing / edge-case-heavy)

config content domain protocol/ — 8 files, -77 LOC
- tightened 3 regexes (MOUSE_TRACKING, looksLikeSlashCommand,
  hasInterpolation — dropped stateful lastIndex dance)
- dead export ParsedSlashCommand removed
- MODES narrowed to `as const`, `.find(m => m === s)` replaces
  `.includes() ? (as cast) : null`
- fortunes.ts hash via reduce
- fmtDuration ternary chain
- inlined aboveViewport predicate in viewport.ts

hooks/ + lib/ — 9 files, -38 LOC
- ANSI_RE via String.fromCharCode(27) + WS_RE lifted to module
  scope (no more eslint-disable no-control-regex)
- compactPreview/edgePreview/thinkingPreview → ternary arrows
- useCompletion: hoisted pathReplace, moved stale-ref guard earlier
- useInputHistory: dropped useCallback wrapper (append is stable)
- useVirtualHistory: replaced 4× any with unknown + narrow
  MeasuredNode interface + one cast site

root TS — 3 files, -63 LOC
- banner.ts: parseRichMarkup via matchAll instead of exec/lastIndex,
  artWidth via reduce
- gatewayClient.ts: resolvePython candidate list collapse, inlined
  one-branch guards in dispatch/pushLog/drain/request
- types.ts: alpha-sorted ActiveTool / Msg / SudoReq / SecretReq
  members

eslint config
- disabled react-hooks/exhaustive-deps on packages/hermes-ink/**
  (compiled by react/compiler, deps live in $[N] memo arrays that
  eslint can't introspect) and removed the now-orphan in-file
  disable directive in ScrollBox.tsx

fixes (not from the cleaner pass)
- useComposerState: unlinkSync(file) + try/catch → rmSync(file,
  { force: true }) — kills the no-empty lint error and is more
  idiomatic
- useConfigSync: added setBellOnComplete + setVoiceEnabled to the
  two useEffect dep arrays (they're stable React setState setters;
  adding is safe and silences exhaustive-deps)

verification
- npx eslint src/ packages/ → 0 errors, 0 warnings
- npm run type-check → clean
- npm test → 50/50
- npm run build → 394.8kb ink-bundle.js, 11ms esbuild
- pytest tests/tui_gateway/ tests/test_tui_gateway_server.py
  tests/hermes_cli/test_tui_resume_flow.py
  tests/hermes_cli/test_tui_npm_install.py → 57/57

ui-tui/src/app/slash/commands/core.ts

@@ -9,12 +9,12 @@ import { patchUiState } from '../../uiStore.js'
 import type { SlashCommand } from '../types.js'
 
 const flagFromArg = (arg: string, current: boolean): boolean | null => {
-  const mode = arg.trim().toLowerCase()
-
   if (!arg) {
     return !current
   }
 
+  const mode = arg.trim().toLowerCase()
+
   if (mode === 'on') {
     return true
   }
@@ -46,14 +46,16 @@ export const coreCommands: SlashCommand[] = [
         sections.push({ text: `${ctx.local.catalog.skillCount} skill commands available — /skills to browse` })
       }
 
-      sections.push({
-        rows: [
-          ['/details [hidden|collapsed|expanded|cycle]', 'set agent detail visibility mode'],
-          ['/fortune [random|daily]', 'show a random or daily local fortune']
-        ],
-        title: 'TUI'
-      })
-      sections.push({ rows: HOTKEYS, title: 'Hotkeys' })
+      sections.push(
+        {
+          rows: [
+            ['/details [hidden|collapsed|expanded|cycle]', 'set agent detail visibility mode'],
+            ['/fortune [random|daily]', 'show a random or daily local fortune']
+          ],
+          title: 'TUI'
+        },
+        { rows: HOTKEYS, title: 'Hotkeys' }
+      )
 
       ctx.transcript.panel(ctx.ui.theme.brand.helpHeader, sections)
     }

ui-tui/src/app/slash/commands/ops.ts

@@ -9,7 +9,7 @@ export const opsCommands: SlashCommand[] = [
       const [subcommand, ...names] = arg.trim().split(/\s+/).filter(Boolean)
 
       if (subcommand !== 'disable' && subcommand !== 'enable') {
-        return // py prints lists / show / usage
+        return
       }
 
       if (!names.length) {

ui-tui/src/app/slash/commands/session.ts

@@ -109,7 +109,7 @@ export const sessionCommands: SlashCommand[] = [
     name: 'personality',
     run: (arg, ctx) => {
       if (!arg) {
-        return // py handles listing
+        return
       }
 
       ctx.gateway.rpc<ConfigSetResponse>('config.set', { key: 'personality', session_id: ctx.sid, value: arg }).then(
@@ -200,11 +200,6 @@ export const sessionCommands: SlashCommand[] = [
     }
   },
 
-  // The four shims below call `config.set` directly because Python's `slash.exec`
-  // worker is a separate subprocess — it writes config but does NOT fire the
-  // live side-effects (`skin.changed` event, agent.reasoning_config,
-  // agent.verbose_logging, per-session yolo flip). Direct RPC does.
-
   {
     help: 'switch theme skin (fires skin.changed)',
     name: 'skin',

ui-tui/src/app/slash/registry.ts

@@ -5,14 +5,8 @@ import type { SlashCommand } from './types.js'
 
 export const SLASH_COMMANDS: SlashCommand[] = [...coreCommands, ...sessionCommands, ...opsCommands]
 
-const byName = new Map<string, SlashCommand>()
+const byName = new Map<string, SlashCommand>(
+  SLASH_COMMANDS.flatMap(cmd => [cmd.name, ...(cmd.aliases ?? [])].map(name => [name, cmd] as const))
+)
 
-for (const cmd of SLASH_COMMANDS) {
-  byName.set(cmd.name, cmd)
-
-  for (const alias of cmd.aliases ?? []) {
-    byName.set(alias, cmd)
-  }
-}
-
-export const findSlashCommand = (name: string): SlashCommand | undefined => byName.get(name.toLowerCase())
+export const findSlashCommand = (name: string) => byName.get(name.toLowerCase())