mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-25 00:51:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test(skills): add regression tests for null metadata frontmatter

Browse source 
Covers the case where a SKILL.md has `metadata:` (null) or
`metadata.hermes:` (null), which caused an AttributeError
before the fix in d218cf91.

Made-with: Cursor
This commit is contained in:
Teknium 2026-03-25 16:09:27 -07:00
parent f7f30aaab9
commit 37cabc47d3
No known key found for this signature in database
1 changed files with 29 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

29
tests/agent/test_prompt_builder.py
View file

@ -878,3 +878,32 @@ class TestBuildSkillsSystemPromptConditional:
)
result = build_skills_system_prompt()
assert "duckduckgo" in result
def test_null_metadata_does_not_crash(self, monkeypatch, tmp_path):
"""Regression: metadata key present but null should not AttributeError."""
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
skill_dir = tmp_path / "skills" / "general" / "safe-skill"
skill_dir.mkdir(parents=True)
# YAML `metadata:` with no value parses as {"metadata": None}
(skill_dir / "SKILL.md").write_text(
"---\nname: safe-skill\ndescription: Survives null metadata\nmetadata:\n---\n"
)
result = build_skills_system_prompt(
available_tools=set(),
available_toolsets=set(),
)
assert "safe-skill" in result
def test_null_hermes_under_metadata_does_not_crash(self, monkeypatch, tmp_path):
"""Regression: metadata.hermes present but null should not crash."""
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
skill_dir = tmp_path / "skills" / "general" / "nested-null"
skill_dir.mkdir(parents=True)
(skill_dir / "SKILL.md").write_text(
"---\nname: nested-null\ndescription: Null hermes key\nmetadata:\n hermes:\n---\n"
)
result = build_skills_system_prompt(
available_tools=set(),
available_toolsets=set(),
)
assert "nested-null" in result