mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-01 12:02:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(desktop): force app exit after update/uninstall handoff on macOS
Some checks are pending
CI / Detect affected areas (push) Waiting to run
Details
CI / Python tests (push) Blocked by required conditions
Details
CI / Python lints (push) Blocked by required conditions
Details
CI / TypeScript (push) Blocked by required conditions
Details
CI / Docs Site (push) Blocked by required conditions
Details
CI / Deny unrelated histories (push) Blocked by required conditions
Details
CI / Check contributors (push) Blocked by required conditions
Details
CI / Check uv.lock (push) Blocked by required conditions
Details
CI / Lint Docker scripts (push) Blocked by required conditions
Details
CI / Build&Test Docker image (push) Blocked by required conditions
Details
CI / Supply-chain scan (push) Blocked by required conditions
Details
CI / OSV scan (push) Waiting to run
Details
CI / All required checks pass (push) Blocked by required conditions
Details
Deploy Site / deploy-vercel (push) Waiting to run
Details
Deploy Site / deploy-docs (push) Waiting to run
Details

Browse source 
On macOS app.quit() closes windows but window-all-closed deliberately keeps
the process alive (Dock convention). Every detached hand-off (update swap,
relaunch, Windows bootstrap recovery, uninstall cleanup) waits for the
desktop PID to exit before replacing/removing the bundle — so the process
never dying means the script spins its full PID-wait and the user sees a
blank app, or an uninstall that appears to do nothing.

Add a module-level isQuittingForHandoff flag, set before every hand-off
app.quit(); window-all-closed then quits on all platforms when it's set.

Covers all five hand-off sites including the Linux relaunch path.
This commit is contained in:
Brad Hallett 2026-06-28 04:22:11 -07:00 • committed by Teknium
parent e54bedd8ea
commit 376d021fee
2 changed files with 23 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
scripts/release.py
View file

@ -48,6 +48,7 @@ AUTHOR_MAP = {
"prathamesh290504@gmail.com": "PRATHAMESH75", # PR #37550 salvage (ExecStopPost cgroup-orphan reaper to unblock systemd restart; #37454)
"der@konsi.org": "konsisumer", # PR #19608 salvage (read-modify-write merge in write_credential_pool to preserve concurrently-added credentials; #19566)
"linyubin@users.noreply.github.com": "linyubin", # PR #50228 salvage (eager fallback on persistent transport timeout/overloaded; #22277)
"bradhallett@users.noreply.github.com": "bradhallett", # PR #46948 salvage (force app exit after update/uninstall handoff on macOS; #46948)
"65363919+coygeek@users.noreply.github.com": "coygeek", # PR #37951 salvage (fail closed when provider env blocklist import fails; #37950)
"5261694+djstunami@users.noreply.github.com": "djstunami", # PR #5316 salvage / co-author (suppress transient check_fn flakes so subagents keep file/terminal tools; #21658 / #5304)
"jmmaloney4@gmail.com": "jmmaloney4", # PR #25206 salvage (re-select credential pool on primary runtime restore; #25205)