mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-06-08 08:11:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

fix(run_agent): strip temperature from flush_memories Codex fallback path

Browse source 
When the auxiliary client fails for any reason (_call_llm raises), the
codex_responses fallback path explicitly set codex_kwargs["temperature"] =
_flush_temperature (0.3). _run_codex_stream then sent this to the Codex
Responses endpoint (chatgpt.com/backend-api/codex), which rejects
temperature with HTTP 400 "Unsupported parameter: temperature".

The error propagated to the outer except block and surfaced as
"Auxiliary memory flush failed: HTTP 400 - Unsupported parameter:
temperature", misleadingly pointing at temperature rather than the
original aux failure.

Fix: strip temperature unconditionally from codex_kwargs before calling
_run_codex_stream, consistent with how _CodexCompletionsAdapter already
omits temperature from Responses API calls.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Basit Mustafa 2026-04-24 15:21:03 -07:00
parent 8ea389a7f8
commit 3756d84dfe
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
run_agent.py
View file

@ -5084,7 +5084,6 @@ class AIAgent:
def _run_codex_stream(self, api_kwargs: dict, client: Any = None, on_first_delta: callable = None):
"""Execute one streaming Responses API request and return the final response."""
import httpx as _httpx
active_client = client or self._ensure_primary_openai_client(reason="codex_stream_direct")
max_stream_retries = 1
has_tool_calls = False
@ -7938,10 +7937,8 @@ class AIAgent:
codex_kwargs["tools"] = _ct_flush.convert_tools([memory_tool_def])
elif not codex_kwargs.get("tools"):
codex_kwargs["tools"] = [memory_tool_def]
if _flush_temperature is not None:
codex_kwargs["temperature"] = _flush_temperature
else:
codex_kwargs.pop("temperature", None)
# Codex Responses endpoint does not accept temperature — strip it
codex_kwargs.pop("temperature", None)
if "max_output_tokens" in codex_kwargs:
codex_kwargs["max_output_tokens"] = 5120
response = self._run_codex_stream(codex_kwargs)