mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-24 16:54:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(openviking): sanitize splitline env separators

Browse source
This commit is contained in:
Hao Zhe 2026-07-05 05:33:22 +08:00 • committed by kshitij
parent 35d3ade3aa
commit 36f01d2e54
2 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/memory/openviking/__init__.py
View file

@ -972,11 +972,11 @@ def _env_line_safe(value: Any) -> str:
``read_text().splitlines()`` round-trip — letting a malformed or pasted
secret (e.g. an api_key copied with a trailing record) inject an
arbitrary additional variable into the persisted credentials file. Strip
the line terminators (``\r``, ``\n``) and the NUL byte so a value can
only ever occupy the single line it is written on.
the line separators recognized by ``splitlines()`` and the NUL byte so a
value can only ever occupy the single line it is written on.
"""
text = value if isinstance(value, str) else str(value)
return text.replace("\r", "").replace("\n", "").replace("\x00", "")
return "".join(text.replace("\x00", "").splitlines())
def _write_env_vars(env_path: Path, env_writes: dict, remove_keys: tuple[str, ...] = ()) -> None:

12
tests/plugins/memory/test_openviking_provider.py
View file

@ -110,6 +110,18 @@ def test_openviking_env_writer_strips_embedded_newlines_in_values(tmp_path):
assert "INJECTED_KEY" not in parsed
def test_openviking_env_writer_strips_splitline_separators_and_nul(tmp_path):
env_path = tmp_path / ".env"
openviking_module._write_env_vars(
env_path,
{"OPENVIKING_API_KEY": "good\u2028INJECTED_KEY=attacker\x00tail"},
)
lines = env_path.read_text(encoding="utf-8").splitlines()
assert lines == ["OPENVIKING_API_KEY=goodINJECTED_KEY=attackertail"]
def test_openviking_env_writer_strips_newlines_when_updating_existing_key(tmp_path):
env_path = tmp_path / ".env"
env_path.write_text("OPENVIKING_API_KEY=old\n", encoding="utf-8")