fix(kanban): preserve notifier_profile for dashboard home subscriptions

This commit is contained in:
Zyrixtrex 2026-05-18 20:14:39 -07:00 committed by Teknium
parent afae2dd9ec
commit 326c15d955
3 changed files with 53 additions and 0 deletions

View file

@ -4762,6 +4762,18 @@ def add_notify_sub(
""",
(task_id, platform, chat_id, thread_id or "", user_id, notifier_profile, now),
)
if notifier_profile:
# Self-heal legacy rows that predate notifier ownership by
# backfilling only when the existing value is unset.
conn.execute(
"""
UPDATE kanban_notify_subs
SET notifier_profile = ?
WHERE task_id = ? AND platform = ? AND chat_id = ? AND thread_id = ?
AND (notifier_profile IS NULL OR notifier_profile = '')
""",
(notifier_profile, task_id, platform, chat_id, thread_id or ""),
)
def list_notify_subs(

View file

@ -1207,6 +1207,15 @@ def _configured_home_channels() -> list[dict]:
return result
def _active_profile_name() -> str:
"""Return the current Hermes profile name for notify-sub ownership."""
try:
from hermes_cli.profiles import get_active_profile_name
return get_active_profile_name() or "default"
except Exception:
return "default"
def _home_sub_matches(sub: dict, home: dict) -> bool:
"""True if a notify_subs row corresponds to the given home channel."""
return (
@ -1278,6 +1287,7 @@ def subscribe_home(task_id: str, platform: str, board: Optional[str] = Query(Non
platform=platform,
chat_id=home["chat_id"],
thread_id=home["thread_id"] or None,
notifier_profile=_active_profile_name(),
)
return {"ok": True, "task_id": task_id, "home_channel": home}
finally:

View file

@ -1353,6 +1353,7 @@ def test_home_subscribe_creates_notify_sub_row(client, with_home_channels):
assert subs[0]["platform"] == "telegram"
assert subs[0]["chat_id"] == "1234567"
assert subs[0]["thread_id"] == "42"
assert subs[0]["notifier_profile"] == "default"
def test_home_subscribe_flips_subscribed_flag_in_subsequent_get(client, with_home_channels):
@ -1380,6 +1381,36 @@ def test_home_subscribe_is_idempotent(client, with_home_channels):
conn.close()
def test_home_subscribe_backfills_owner_on_legacy_row(client, with_home_channels):
"""Re-subscribing should backfill notifier ownership on ownerless rows."""
from hermes_cli import kanban_db as kb
t = client.post("/api/plugins/kanban/tasks", json={"title": "x"}).json()["task"]
conn = kb.connect()
try:
kb.add_notify_sub(
conn,
task_id=t["id"],
platform="telegram",
chat_id="1234567",
thread_id="42",
)
finally:
conn.close()
r = client.post(f"/api/plugins/kanban/tasks/{t['id']}/home-subscribe/telegram")
assert r.status_code == 200
conn = kb.connect()
try:
subs = kb.list_notify_subs(conn, t["id"])
finally:
conn.close()
assert len(subs) == 1
assert subs[0]["notifier_profile"] == "default"
def test_home_subscribe_unknown_platform_returns_404(client, with_home_channels):
"""Platforms without a home configured (slack in the fixture) return 404."""
t = client.post("/api/plugins/kanban/tasks", json={"title": "x"}).json()["task"]