mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-25 00:51:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(tui): render inline diffs inside assistant completion

Browse source 
Follow-up for #13729: segment-level system artifacts still looked detached in real flow.\n\nInstead of appending inline_diff as a standalone segment/system row, queue sanitized diffs during tool.complete and append them as a fenced diff block to the assistant completion text on message.complete. This keeps the diff in the same message flow as the assistant response.
This commit is contained in:
Brooklyn Nicholson 2026-04-21 19:02:53 -05:00
parent bddf0cd61e
commit 31b3b09ea4
3 changed files with 30 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

23
ui-tui/src/__tests__/createGatewayEventHandler.test.ts
View file

@ -143,7 +143,7 @@ describe('createGatewayEventHandler', () => {
expect(appended[0]?.thinkingTokens).toBe(estimateTokensRough(fromServer))
})
it('routes inline_diff into the active segment stream, not historyItems', () => {
it('attaches inline_diff to the assistant completion body', () => {
const appended: Msg[] = []
const onEvent = createGatewayEventHandler(buildCtx(appended))
const diff = '\u001b[31m--- a/foo.ts\u001b[0m\n\u001b[32m+++ b/foo.ts\u001b[0m\n@@\n-old\n+new'
@ -158,26 +158,21 @@ describe('createGatewayEventHandler', () => {
type: 'tool.complete'
} as any)
// While streaming, nothing has flowed to historyItems yet — diff must be
// held in segmentMessages so the transcript renders it inline with the
// current turn rather than above it.
// Diff is buffered for message.complete and sanitized (ANSI stripped).
expect(appended).toHaveLength(0)
expect(turnController.segmentMessages).toContainEqual(
expect.objectContaining({ kind: 'trail', role: 'system', text: '' })
)
expect(turnController.segmentMessages).toContainEqual({ role: 'system', text: cleaned })
expect(turnController.pendingInlineDiffs).toEqual([cleaned])
onEvent({
payload: { text: 'patch applied' },
type: 'message.complete'
} as any)
// After the turn closes, the diff lands in history in the order the
// gateway emitted it — before the assistant's final text, not above it.
expect(appended).toHaveLength(3)
expect(appended[0]).toMatchObject({ kind: 'trail', role: 'system', text: '' })
expect(appended[1]).toMatchObject({ role: 'system', text: cleaned })
expect(appended[2]).toMatchObject({ role: 'assistant', text: 'patch applied' })
// Diff is rendered in the same assistant message body as the completion.
expect(appended).toHaveLength(1)
expect(appended[0]).toMatchObject({ role: 'assistant' })
expect(appended[0]?.text).toContain('patch applied')
expect(appended[0]?.text).toContain('```diff')
expect(appended[0]?.text).toContain(cleaned)
})
it('shows setup panel for missing provider startup error', () => {