mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-08 13:12:08 +00:00
fix(docker): widen docker_network to file/code-exec paths + guard container reuse
Follow-up to the salvaged toggle commit: - file_tools.py / code_execution_tool.py: carry docker_network in their container_config dicts so those environment-creation paths honor the lockdown instead of silently defaulting back to bridge (the probe/exec asymmetry class reported on #46358). - docker.py: cross-process reuse now inspects HostConfig.NetworkMode when docker_network=false and removes a mismatched (networked) container before starting a fresh air-gapped one. Fails closed when inspect fails. Default-network config never churns containers, so operators using docker_extra_args --network=none are unaffected. - tests: AST invariant that every container_config site carrying docker_run_as_host_user also carries docker_network, plus three reuse guard tests (reject bridge under lockdown / keep matching none / no inspect when network enabled). - docs: configuration.md gains terminal.docker_network + env var row.
This commit is contained in:
parent
cd2b360d64
commit
3167dbaee2
5 changed files with 174 additions and 0 deletions
|
|
@ -684,6 +684,7 @@ def _get_or_create_env(task_id: str):
|
|||
"container_persistent": config.get("container_persistent", True),
|
||||
"docker_volumes": config.get("docker_volumes", []),
|
||||
"docker_run_as_host_user": config.get("docker_run_as_host_user", False),
|
||||
"docker_network": config.get("docker_network", True),
|
||||
}
|
||||
|
||||
ssh_config = None
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue