mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-20 15:33:54 +00:00
fix(tools): validate acp_command binary exists before forcing copilot-acp transport
When a model passes `acp_command="copilot"` (or any other binary name) in a `delegate_task` tool call, `_build_child_agent` unconditionally sets `effective_provider = "copilot-acp"`, which routes the subagent through `CopilotACPClient`. That client spawns the named binary via subprocess; if it isn't on PATH, every retry raises RuntimeError and an asyncio cleanup race during error delivery can take the entire gateway down. This is a real failure mode on headless deploys (Railway / Fly / VPS / Docker) where `copilot` / `claude` / etc. aren't installed. The schema does say "Do NOT set unless the user explicitly told you an ACP CLI is installed," but models occasionally pass it anyway — particularly for X (Twitter) search prompts where Grok seems to associate ACP with "search assistance." Reproduction: - Headless install (no `copilot` binary on PATH) - Set provider to xai-oauth + model grok-4.3 - Telegram prompt: "Search X for crypto twitter trends" - Grok decides to delegate and passes `acp_command="copilot"` - Subagent crashes 3x, gateway crashes on the 3rd retry teardown Fix: validate the binary exists on PATH via `shutil.which` before honoring the override. If missing, log a warning and fall through to the parent's default transport. No behavior change when the binary IS present (covered by `test_build_child_agent_honors_acp_command_when_binary_present`). Tests: - `test_build_child_agent_ignores_acp_command_when_binary_missing` - `test_build_child_agent_honors_acp_command_when_binary_present` Verified on Python 3.11 (macOS) and 3.12 (Debian 13 container). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
6d6702ef50
commit
2e0b591076
2 changed files with 101 additions and 0 deletions
|
|
@ -1229,6 +1229,22 @@ def _build_child_agent(
|
|||
effective_api_mode = None # force re-derivation from provider's defaults
|
||||
else:
|
||||
effective_api_mode = getattr(parent_agent, "api_mode", None)
|
||||
# Defensive: validate override_acp_command exists on PATH before honoring
|
||||
# it. Models occasionally pass acp_command="copilot" / "claude" / etc. in
|
||||
# delegate_task tool calls despite the schema saying not to, which forces
|
||||
# the subagent onto the copilot-acp transport below and crashes the
|
||||
# gateway when the binary is missing (e.g. headless container deploys).
|
||||
if override_acp_command:
|
||||
import shutil as _shutil
|
||||
|
||||
if not _shutil.which(override_acp_command):
|
||||
logger.warning(
|
||||
"Ignoring acp_command=%r: binary not found on PATH; "
|
||||
"falling back to default transport.",
|
||||
override_acp_command,
|
||||
)
|
||||
override_acp_command = None
|
||||
override_acp_args = None
|
||||
effective_acp_command = override_acp_command or getattr(
|
||||
parent_agent, "acp_command", None
|
||||
)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue