mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-07 02:51:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(setup): skip AUXILIARY_VISION_MODEL write when input is blank

Browse source 
Guard the save_env_value('AUXILIARY_VISION_MODEL', ...) call with
'if _selected_vision_model:' so blank input at the non-OpenAI vision
model prompt doesn't nuke existing values in .env.

save_env_value has no internal guard against empty strings — it
faithfully writes whatever it receives, including empty values that
shadow the previously-configured model.

Salvage of #15504 (core hunk). Contributor's test was dropped because
it collided with subsequent test refactors; the fix stands on its own.

Co-authored-by: alt-glitch <balyan.sid@gmail.com>
This commit is contained in:
alt-glitch 2026-05-04 02:41:25 -07:00 • committed by Teknium
parent 7d36533aeb
commit 2a52e28568
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
hermes_cli/setup.py
View file

@ -964,6 +964,7 @@ def setup_model_provider(config: dict, *, quick: bool = False):
) )
else: else:
_selected_vision_model = prompt(" Vision model (blank = use main/custom default)").strip() _selected_vision_model = prompt(" Vision model (blank = use main/custom default)").strip()
if _selected_vision_model:
save_env_value("AUXILIARY_VISION_MODEL", _selected_vision_model) save_env_value("AUXILIARY_VISION_MODEL", _selected_vision_model)
print_success( print_success(
f"Vision configured with {_base_url}" f"Vision configured with {_base_url}"