test: remove 169 change-detector tests across 21 files (#11472)

First pass of test-suite reduction to address flaky CI and bloat.

Removed tests that fall into these change-detector patterns:

1. Source-grep tests (tests/gateway/test_feishu.py, test_email.py): tests
   that call inspect.getsource() on production modules and grep for string
   literals. Break on any refactor/rename even when behavior is correct.

2. Platform enum tautologies (every gateway/test_X.py): assertions like
   `Platform.X.value == 'x'` duplicated across ~9 adapter test files.

3. Toolset/PLATFORM_HINTS/setup-wizard registry-presence checks: tests that
   only verify a key exists in a dict. Data-layout tests, not behavior.

4. Argparse wiring tests (test_argparse_flag_propagation, test_subparser_routing
   _fallback): tests that do parser.parse_args([...]) then assert args.field.
   Tests Python's argparse, not our code.

5. Pure dispatch tests (test_plugins_cmd.TestPluginsCommandDispatch): patch
   cmd_X, call plugins_command with matching action, assert mock called.
   Tests the if/elif chain, not behavior.

6. Kwarg-to-mock verification (test_auxiliary_client ~45 tests,
   test_web_tools_config, test_gemini_cloudcode, test_retaindb_plugin): tests
   that mock the external API client, call our function, and assert exact
   kwargs. Break on refactor even when behavior is preserved.

7. Schedule-internal "function-was-called" tests (acp/test_server scheduling
   tests): tests that patch own helper method, then assert it was called.

Kept behavioral tests throughout: error paths (pytest.raises), security
tests (path traversal, SSRF, redaction), message alternation invariants,
provider API format conversion, streaming logic, memory contract, real
config load/merge tests.

Net reduction: 169 tests removed. 38 empty classes cleaned up.

Collected before: 12,522 tests
Collected after:  12,353 tests
This commit is contained in:
Teknium 2026-04-17 01:05:09 -07:00 committed by GitHub
parent e33cb65a98
commit 2367c6ffd5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
21 changed files with 0 additions and 1946 deletions

View file

@ -63,38 +63,6 @@ class TestFirecrawlClientConfig:
# ── Configuration matrix ─────────────────────────────────────────
def test_cloud_mode_key_only(self):
"""API key without URL → cloud Firecrawl."""
with patch.dict(os.environ, {"FIRECRAWL_API_KEY": "fc-test"}):
with patch("tools.web_tools.Firecrawl") as mock_fc:
from tools.web_tools import _get_firecrawl_client
result = _get_firecrawl_client()
mock_fc.assert_called_once_with(api_key="fc-test")
assert result is mock_fc.return_value
def test_self_hosted_with_key(self):
"""Both key + URL → self-hosted with auth."""
with patch.dict(os.environ, {
"FIRECRAWL_API_KEY": "fc-test",
"FIRECRAWL_API_URL": "http://localhost:3002",
}):
with patch("tools.web_tools.Firecrawl") as mock_fc:
from tools.web_tools import _get_firecrawl_client
result = _get_firecrawl_client()
mock_fc.assert_called_once_with(
api_key="fc-test", api_url="http://localhost:3002"
)
assert result is mock_fc.return_value
def test_self_hosted_no_key(self):
"""URL only, no key → self-hosted without auth."""
with patch.dict(os.environ, {"FIRECRAWL_API_URL": "http://localhost:3002"}):
with patch("tools.web_tools.Firecrawl") as mock_fc:
from tools.web_tools import _get_firecrawl_client
result = _get_firecrawl_client()
mock_fc.assert_called_once_with(api_url="http://localhost:3002")
assert result is mock_fc.return_value
def test_no_config_raises_with_helpful_message(self):
"""Neither key nor URL → ValueError with guidance."""
with patch("tools.web_tools.Firecrawl"):
@ -169,18 +137,6 @@ class TestFirecrawlClientConfig:
api_url="https://firecrawl-gateway.nousresearch.com",
)
def test_direct_mode_is_preferred_over_tool_gateway(self):
"""Explicit Firecrawl config should win over the gateway fallback."""
with patch.dict(os.environ, {
"FIRECRAWL_API_KEY": "fc-test",
"TOOL_GATEWAY_DOMAIN": "nousresearch.com",
}):
with patch("tools.web_tools._read_nous_access_token", return_value="nous-token"):
with patch("tools.web_tools.Firecrawl") as mock_fc:
from tools.web_tools import _get_firecrawl_client
_get_firecrawl_client()
mock_fc.assert_called_once_with(api_key="fc-test")
def test_nous_auth_token_respects_hermes_home_override(self, tmp_path):
"""Auth lookup should read from HERMES_HOME/auth.json, not ~/.hermes/auth.json."""
real_home = tmp_path / "real-home"
@ -275,18 +231,6 @@ class TestFirecrawlClientConfig:
# ── Edge cases ───────────────────────────────────────────────────
def test_empty_string_key_treated_as_absent(self):
"""FIRECRAWL_API_KEY='' should not be passed as api_key."""
with patch.dict(os.environ, {
"FIRECRAWL_API_KEY": "",
"FIRECRAWL_API_URL": "http://localhost:3002",
}):
with patch("tools.web_tools.Firecrawl") as mock_fc:
from tools.web_tools import _get_firecrawl_client
_get_firecrawl_client()
# Empty string is falsy, so only api_url should be passed
mock_fc.assert_called_once_with(api_url="http://localhost:3002")
def test_empty_string_key_no_url_raises(self):
"""FIRECRAWL_API_KEY='' with no URL → should raise."""
with patch.dict(os.environ, {"FIRECRAWL_API_KEY": ""}):