test: remove 169 change-detector tests across 21 files (#11472)

First pass of test-suite reduction to address flaky CI and bloat.

Removed tests that fall into these change-detector patterns:

1. Source-grep tests (tests/gateway/test_feishu.py, test_email.py): tests
   that call inspect.getsource() on production modules and grep for string
   literals. Break on any refactor/rename even when behavior is correct.

2. Platform enum tautologies (every gateway/test_X.py): assertions like
   `Platform.X.value == 'x'` duplicated across ~9 adapter test files.

3. Toolset/PLATFORM_HINTS/setup-wizard registry-presence checks: tests that
   only verify a key exists in a dict. Data-layout tests, not behavior.

4. Argparse wiring tests (test_argparse_flag_propagation, test_subparser_routing
   _fallback): tests that do parser.parse_args([...]) then assert args.field.
   Tests Python's argparse, not our code.

5. Pure dispatch tests (test_plugins_cmd.TestPluginsCommandDispatch): patch
   cmd_X, call plugins_command with matching action, assert mock called.
   Tests the if/elif chain, not behavior.

6. Kwarg-to-mock verification (test_auxiliary_client ~45 tests,
   test_web_tools_config, test_gemini_cloudcode, test_retaindb_plugin): tests
   that mock the external API client, call our function, and assert exact
   kwargs. Break on refactor even when behavior is preserved.

7. Schedule-internal "function-was-called" tests (acp/test_server scheduling
   tests): tests that patch own helper method, then assert it was called.

Kept behavioral tests throughout: error paths (pytest.raises), security
tests (path traversal, SSRF, redaction), message alternation invariants,
provider API format conversion, streaming logic, memory contract, real
config load/merge tests.

Net reduction: 169 tests removed. 38 empty classes cleaned up.

Collected before: 12,522 tests
Collected after:  12,353 tests
This commit is contained in:
Teknium 2026-04-17 01:05:09 -07:00 committed by GitHub
parent e33cb65a98
commit 2367c6ffd5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
21 changed files with 0 additions and 1946 deletions

View file

@ -173,60 +173,6 @@ class TestMemoryPluginCliDiscovery:
# ── Honcho register_cli ──────────────────────────────────────────────────
class TestHonchoRegisterCli:
def test_builds_subcommand_tree(self):
"""register_cli creates the expected subparser tree."""
from plugins.memory.honcho.cli import register_cli
parser = argparse.ArgumentParser()
register_cli(parser)
# Verify key subcommands exist by parsing them
args = parser.parse_args(["status"])
assert args.honcho_command == "status"
args = parser.parse_args(["peer", "--user", "alice"])
assert args.honcho_command == "peer"
assert args.user == "alice"
args = parser.parse_args(["mode", "tools"])
assert args.honcho_command == "mode"
assert args.mode == "tools"
args = parser.parse_args(["tokens", "--context", "500"])
assert args.honcho_command == "tokens"
assert args.context == 500
args = parser.parse_args(["--target-profile", "coder", "status"])
assert args.target_profile == "coder"
assert args.honcho_command == "status"
def test_setup_redirects_to_memory_setup(self):
"""hermes honcho setup redirects to memory setup."""
from plugins.memory.honcho.cli import register_cli
parser = argparse.ArgumentParser()
register_cli(parser)
args = parser.parse_args(["setup"])
assert args.honcho_command == "setup"
def test_mode_choices_are_recall_modes(self):
"""Mode subcommand uses recall mode choices (hybrid/context/tools)."""
from plugins.memory.honcho.cli import register_cli
parser = argparse.ArgumentParser()
register_cli(parser)
# Valid recall modes should parse
for mode in ("hybrid", "context", "tools"):
args = parser.parse_args(["mode", mode])
assert args.mode == mode
# Old memoryMode values should fail
with pytest.raises(SystemExit):
parser.parse_args(["mode", "honcho"])
# ── ProviderCollector no-op ──────────────────────────────────────────────