mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-06-18 09:51:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Merge pull request #47973 from kshitijk4poor/fix/ov-skill-scaffolding

Browse source 
fix(tests): type-correct OpenViking skill-scaffolding test sentinels
This commit is contained in:
kshitij 2026-06-17 23:49:25 +05:30 • committed by GitHub
commit 1e6c4ba74f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
tests/openviking_plugin/test_openviking.py
View file

@ -1,6 +1,7 @@
"""Tests for plugins/memory/openviking/__init__.py — URI normalization and payload handling."""
import json
from typing import Any, cast
import plugins.memory.openviking as openviking_plugin
from plugins.memory.openviking import OpenVikingMemoryProvider
@ -127,7 +128,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider()
provider._client = object()
provider._client = cast(Any, object())
provider._endpoint = "http://openviking.test"
provider._api_key = ""
provider._account = "default"
@ -143,6 +144,7 @@ class TestOpenVikingSkillQuerySafety:
)
provider.queue_prefetch(skill_message)
assert provider._prefetch_thread is not None
provider._prefetch_thread.join(timeout=5.0)
assert RecordingVikingClient.calls == [
@ -156,7 +158,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider()
provider._client = object()
provider._client = cast(Any, object())
provider._endpoint = "http://openviking.test"
provider._api_key = ""
provider._account = "default"
@ -173,6 +175,7 @@ class TestOpenVikingSkillQuerySafety:
)
provider.queue_prefetch(skill_message)
assert provider._prefetch_thread is not None
provider._prefetch_thread.join(timeout=5.0)
assert RecordingVikingClient.calls == [
@ -186,7 +189,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider()
provider._client = object()
provider._client = cast(Any, object())
skill_message = (
'[IMPORTANT: The user has invoked the "skill-creator" skill, indicating they want '
"you to follow its instructions. The full skill content is loaded below.]\n\n"
@ -203,7 +206,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider()
provider._client = object()
provider._client = cast(Any, object())
provider._endpoint = "http://openviking.test"
provider._api_key = ""
provider._account = "default"
@ -220,6 +223,7 @@ class TestOpenVikingSkillQuerySafety:
)
provider.sync_turn(skill_message, "Done.")
assert provider._sync_thread is not None
provider._sync_thread.join(timeout=5.0)
assert RecordingVikingClient.calls == [
@ -237,7 +241,7 @@ class TestOpenVikingSkillQuerySafety:
RecordingVikingClient.calls = []
monkeypatch.setattr(openviking_plugin, "_VikingClient", RecordingVikingClient)
provider = OpenVikingMemoryProvider()
provider._client = object()
provider._client = cast(Any, object())
skill_message = (
'[IMPORTANT: The user has invoked the "skill-creator" skill, indicating they want '
"you to follow its instructions. The full skill content is loaded below.]\n\n"