mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-01 12:02:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(security): add session-id filename sanitizer to prevent path traversal

Browse source 
Session IDs can originate from untrusted input (e.g. the
X-Hermes-Session-Id API header) and are interpolated raw into on-disk
artifact filenames under ~/.hermes/sessions/. A traversal-shaped ID
(../../../../etc/pwned) would let a caller write the session snapshot
or request dump outside the sessions directory.

_safe_session_filename_component() collapses every non [A-Za-z0-9_-]
character to _, caps the length, and appends a short content hash when
sanitization changed the string, always yielding a single traversal-free
path segment.

Closes #5958.
This commit is contained in:
Xowiek 2026-06-29 04:08:31 -07:00 • committed by Teknium
parent cdd8e0a271
commit 1debd5e8f9
1 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

25
run_agent.py
View file

@ -292,6 +292,31 @@ def _qwen_portal_headers() -> dict:
}
def _safe_session_filename_component(session_id: str) -> str:
"""Return a stable, path-safe filename component for a session ID.
Session IDs can originate from untrusted input (e.g. the
``X-Hermes-Session-Id`` API header) and are otherwise interpolated raw
into on-disk artifact filenames under ``~/.hermes/sessions/``. Without
sanitization, a traversal-shaped ID such as ``../../../../etc/pwned``
would let a caller write the session snapshot / request dump outside the
sessions directory. This collapses every non ``[A-Za-z0-9_-]`` character
to ``_`` (so no path separators or ``.`` survive), caps the length, and —
when sanitization changed the string — appends a short content hash so two
distinct IDs that sanitize to the same component don't collide. The
result is always a single, traversal-free path segment.
"""
raw = str(session_id or "").strip()
sanitized = re.sub(r"[^\w-]", "_", raw).strip("._")
sanitized = sanitized[:96] or "session"
if raw and sanitized == raw:
return sanitized
digest = hashlib.sha256(
raw.encode("utf-8", errors="surrogatepass")
).hexdigest()[:12]
return f"{sanitized}_{digest}"
class _StreamErrorEvent(Exception):
"""Synthesized provider error surfaced from a Responses ``error`` SSE frame.