mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-04-28 01:21:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(memory): close embedded Hindsight async client cleanly

Browse source 
HindsightEmbedded.close() delegates to its sync client.close(). When Hermes
created/used that client on the shared async loop, closing it from the main
thread raises 'attached to a different loop' before aiohttp releases the
session — so the ClientSession / TCPConnector leak past provider teardown.

Close the embedded inner async client on the shared loop first via
_run_sync(inner_client.aclose()), then let the wrapper's sync close()
do its daemon/UI bookkeeping.

Salvage of #14605: test placement rebased — appended TestShutdown class
after TestSharedEventLoopLifecycle (which landed on main after the PR was
written). Original author attribution preserved.
This commit is contained in:
maxims-oss 2026-04-26 12:53:53 -07:00 • committed by Teknium
parent bf05b8f4a2
commit 18beb69b49
2 changed files with 32 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/plugins/memory/test_hindsight_provider.py
View file

@ -1102,3 +1102,22 @@ class TestSharedEventLoopLifecycle:
mock_client.aclose.assert_called_once()
assert provider._client is None
class TestShutdown:
def test_local_embedded_shutdown_closes_inner_async_client_on_shared_loop(self, provider):
inner_client = _make_mock_client()
embedded = MagicMock()
embedded._client = inner_client
embedded.close = MagicMock()
provider._mode = "local_embedded"
provider._client = embedded
provider.shutdown()
inner_client.aclose.assert_awaited_once()
embedded.close.assert_called_once()
assert embedded._client is None
assert provider._client is None