mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-08 13:12:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(photon): bound the sidecar dep self-heal npm run with a timeout

Browse source 
Follow-up to the salvaged #57943: a wedged npm (dead registry, network
blackhole) ran unbounded inside asyncio.to_thread, holding the photon
connect path hostage. Cap npm ci / npm install at 600s; on timeout, log
and leave the stale deps in place so the readiness check reports the
real error and the next reconnect tick retries.
This commit is contained in:
teknium1 2026-07-05 15:09:37 -07:00 • committed by Teknium
parent 3cd93f6aa8
commit 127d2ee87a
1 changed files with 31 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

43
plugins/platforms/photon/adapter.py
View file

@ -85,6 +85,12 @@ _DEDUP_WINDOW_SECONDS = 48 * 3600
_SIDECAR_DIR = Path(__file__).parent / "sidecar"
# Cap on a self-heal `npm ci`/`npm install` of the sidecar deps. A cold
# install of the pinned spectrum-ts tree normally takes well under a minute;
# a wedged npm (dead registry, network blackhole) must not stall the photon
# connect path indefinitely.
_NPM_REINSTALL_TIMEOUT = 600
# Photon / Envoy / spectrum-ts error substrings that indicate a transient
# upstream overload rather than a permanent failure. These are not in the
# core _RETRYABLE_ERROR_PATTERNS because they are specific to this adapter.
@ -168,24 +174,37 @@ def _reinstall_sidecar_deps() -> None:
if not npm:
logger.warning("[photon] cannot reinstall stale sidecar deps: npm not on PATH")
return
result = subprocess.run( # noqa: S603
[npm, "ci"],
cwd=str(_SIDECAR_DIR),
capture_output=True,
text=True,
check=False,
)
if result.returncode != 0:
logger.warning(
"[photon] sidecar `npm ci` failed; falling back to `npm install`"
)
try:
result = subprocess.run( # noqa: S603
[npm, "install"],
[npm, "ci"],
cwd=str(_SIDECAR_DIR),
capture_output=True,
text=True,
check=False,
timeout=_NPM_REINSTALL_TIMEOUT,
)
if result.returncode != 0:
logger.warning(
"[photon] sidecar `npm ci` failed; falling back to `npm install`"
)
result = subprocess.run( # noqa: S603
[npm, "install"],
cwd=str(_SIDECAR_DIR),
capture_output=True,
text=True,
check=False,
timeout=_NPM_REINSTALL_TIMEOUT,
)
except subprocess.TimeoutExpired:
# A wedged npm (dead registry, network blackhole) must not stall the
# photon connect forever — give up, leave the stale deps in place, and
# let the readiness check report the real error. Retried on the next
# reconnect tick.
logger.error(
"[photon] sidecar dependency reinstall timed out after %ss",
_NPM_REINSTALL_TIMEOUT,
)
return
if result.returncode != 0:
logger.error(
"[photon] sidecar dependency reinstall failed: %s",