refactor(desktop): tighten onboarding store + overlay

Drop the dead isOnboardingBusy/BUSY set, factor the catch-fallback dance into safeReq, and share a single reloadAndConnect helper between PKCE submit, device-code success, external recheck, and api-key save.

In the overlay, extract Step / CodeBlock / FlowFooter / CancelBtn / DocsLink atoms so the four sign-in panels share the same chrome instead of repeating it inline. Net effect: fewer literal divs, one place to touch the spacing, and the code-block + footer rows are reusable across future flows.
This commit is contained in:
Brooklyn Nicholson 2026-05-07 23:58:12 -04:00
parent da6b745fff
commit 11d04d9d5e
2 changed files with 214 additions and 256 deletions

View file

@ -38,6 +38,8 @@ interface ApiKeyOption {
short?: string
}
const MIN_KEY_LENGTH = 8
const API_KEY_OPTIONS: ApiKeyOption[] = [
{
id: 'openrouter',
@ -97,17 +99,11 @@ const FLOW_SUBTITLES: Record<OAuthProvider['flow'], string> = {
external: 'Sign in once in your terminal, then come back to chat.'
}
function providerTitle(provider: OAuthProvider) {
return PROVIDER_DISPLAY[provider.id]?.title ?? provider.name
}
const providerTitle = (p: OAuthProvider) => PROVIDER_DISPLAY[p.id]?.title ?? p.name
const orderOf = (p: OAuthProvider) => PROVIDER_DISPLAY[p.id]?.order ?? 99
function sortProviders(providers: OAuthProvider[]) {
return [...providers].sort((a, b) => {
const order = (PROVIDER_DISPLAY[a.id]?.order ?? 99) - (PROVIDER_DISPLAY[b.id]?.order ?? 99)
return order !== 0 ? order : a.name.localeCompare(b.name)
})
}
const sortProviders = (providers: OAuthProvider[]) =>
[...providers].sort((a, b) => orderOf(a) - orderOf(b) || a.name.localeCompare(b.name))
export function DesktopOnboardingOverlay({ enabled, onCompleted, requestGateway }: DesktopOnboardingOverlayProps) {
const onboarding = useStore($desktopOnboarding)
@ -124,28 +120,23 @@ export function DesktopOnboardingOverlay({ enabled, onCompleted, requestGateway
)
useEffect(() => {
if (!enabled && !onboarding.requested) {
return
if (enabled || onboarding.requested) {
void refreshOnboarding(ctx)
}
void refreshOnboarding(ctx)
}, [ctx, enabled, onboarding.requested])
if (!visible) {
return null
}
const { flow } = onboarding
const showPicker = flow.status === 'idle' || flow.status === 'success'
return (
<div className="fixed inset-0 z-1300 flex items-center justify-center bg-background/80 p-6 backdrop-blur-xl">
<div className="w-full max-w-2xl overflow-hidden rounded-3xl border border-border bg-card/95 shadow-2xl">
<Header />
<div className="grid gap-5 p-6">
{onboarding.flow.status === 'idle' || onboarding.flow.status === 'success' ? (
<Picker ctx={ctx} />
) : (
<FlowPanel ctx={ctx} flow={onboarding.flow} />
)}
</div>
<div className="grid gap-5 p-6">{showPicker ? <Picker ctx={ctx} /> : <FlowPanel ctx={ctx} flow={flow} />}</div>
</div>
</div>
)
@ -181,18 +172,18 @@ function Picker({ ctx }: { ctx: OnboardingContext }) {
return (
<div className="grid gap-3">
{providers === null ? (
<Status icon={<Loader2 className="size-4 animate-spin" />}>Looking up providers...</Status>
<Status>Looking up providers...</Status>
) : (
ordered.map(provider => (
<ProviderRow key={provider.id} onSelect={p => void startProviderOAuth(p, ctx)} provider={provider} />
))
)}
<ModeSwitchLink onClick={() => setOnboardingMode('apikey')}>I have an API key</ModeSwitchLink>
<FooterLink onClick={() => setOnboardingMode('apikey')}>I have an API key</FooterLink>
</div>
)
}
function ModeSwitchLink({ children, onClick }: { children: React.ReactNode; onClick: () => void }) {
function FooterLink({ children, onClick }: { children: React.ReactNode; onClick: () => void }) {
return (
<div className="pt-2 text-center">
<button
@ -206,14 +197,7 @@ function ModeSwitchLink({ children, onClick }: { children: React.ReactNode; onCl
)
}
function ProviderRow({
provider,
onSelect
}: {
onSelect: (provider: OAuthProvider) => void
provider: OAuthProvider
}) {
const title = providerTitle(provider)
function ProviderRow({ onSelect, provider }: { onSelect: (provider: OAuthProvider) => void; provider: OAuthProvider }) {
const loggedIn = provider.status?.logged_in
const Trail = provider.flow === 'external' ? ExternalLink : ChevronRight
@ -228,7 +212,7 @@ function ProviderRow({
>
<div className="min-w-0">
<div className="flex items-center gap-2">
<span className="text-sm font-semibold">{title}</span>
<span className="text-sm font-semibold">{providerTitle(provider)}</span>
{loggedIn ? (
<span className="inline-flex items-center gap-1 rounded-full bg-primary/10 px-2 py-0.5 text-xs font-medium text-primary">
<Check className="size-3" />
@ -250,7 +234,7 @@ function ApiKeyForm({ canGoBack, ctx }: { canGoBack: boolean; ctx: OnboardingCon
const [error, setError] = useState<null | string>(null)
const isLocal = option.envKey === 'OPENAI_BASE_URL'
const canSave = value.trim().length >= (isLocal ? 1 : 8)
const canSave = value.trim().length >= (isLocal ? 1 : MIN_KEY_LENGTH)
const submit = async () => {
if (!canSave || saving) {
@ -261,10 +245,10 @@ function ApiKeyForm({ canGoBack, ctx }: { canGoBack: boolean; ctx: OnboardingCon
setError(null)
const result = await saveOnboardingApiKey(option.envKey, value, option.name, ctx)
if (!result.ok) {
setError(result.message ?? 'Could not save credential.')
} else {
if (result.ok) {
setValue('')
} else {
setError(result.message ?? 'Could not save credential.')
}
setSaving(false)
@ -282,6 +266,7 @@ function ApiKeyForm({ canGoBack, ctx }: { canGoBack: boolean; ctx: OnboardingCon
Back to sign in
</button>
) : null}
<div className="grid gap-2 sm:grid-cols-2">
{API_KEY_OPTIONS.map(o => (
<button
@ -309,21 +294,14 @@ function ApiKeyForm({ canGoBack, ctx }: { canGoBack: boolean; ctx: OnboardingCon
<div className="grid gap-2">
<div className="flex items-center justify-between gap-3">
<p className="text-sm leading-6 text-muted-foreground">{option.description}</p>
{option.docsUrl ? (
<Button asChild size="xs" variant="ghost">
<a href={option.docsUrl} rel="noreferrer" target="_blank">
Get a key
<ExternalLink className="size-3" />
</a>
</Button>
) : null}
{option.docsUrl ? <DocsLink href={option.docsUrl}>Get a key</DocsLink> : null}
</div>
<Input
autoComplete="off"
autoFocus
className="font-mono"
onChange={event => setValue(event.target.value)}
onKeyDown={event => event.key === 'Enter' && void submit()}
onChange={e => setValue(e.target.value)}
onKeyDown={e => e.key === 'Enter' && void submit()}
placeholder={option.placeholder || 'Paste API key'}
type={isLocal ? 'text' : 'password'}
value={value}
@ -345,11 +323,11 @@ function FlowPanel({ ctx, flow }: { ctx: OnboardingContext; flow: OnboardingFlow
const title = 'provider' in flow && flow.provider ? providerTitle(flow.provider) : ''
if (flow.status === 'starting') {
return <Status icon={<Loader2 className="size-4 animate-spin" />}>Starting sign-in for {title}...</Status>
return <Status>Starting sign-in for {title}...</Status>
}
if (flow.status === 'submitting') {
return <Status icon={<Loader2 className="size-4 animate-spin" />}>Verifying your code with {title}...</Status>
return <Status>Verifying your code with {title}...</Status>
}
if (flow.status === 'success') {
@ -378,80 +356,45 @@ function FlowPanel({ ctx, flow }: { ctx: OnboardingContext; flow: OnboardingFlow
if (flow.status === 'awaiting_user') {
return (
<div className="grid gap-4">
<div>
<h3 className="text-sm font-semibold">Sign in with {title}</h3>
<ol className="mt-2 list-decimal space-y-1 pl-5 text-sm text-muted-foreground">
<li>We opened {title} in your browser.</li>
<li>Authorize Hermes there.</li>
<li>Copy the authorization code and paste it below.</li>
</ol>
</div>
<Step title={`Sign in with ${title}`}>
<ol className="list-decimal space-y-1 pl-5 text-sm text-muted-foreground">
<li>We opened {title} in your browser.</li>
<li>Authorize Hermes there.</li>
<li>Copy the authorization code and paste it below.</li>
</ol>
<Input
autoFocus
onChange={event => setOnboardingCode(event.target.value)}
onKeyDown={event => event.key === 'Enter' && void submitOnboardingCode(ctx)}
onChange={e => setOnboardingCode(e.target.value)}
onKeyDown={e => e.key === 'Enter' && void submitOnboardingCode(ctx)}
placeholder="Paste authorization code"
value={flow.code}
/>
<div className="flex items-center justify-between gap-3">
<Button asChild size="xs" variant="ghost">
<a href={flow.start.auth_url} rel="noreferrer" target="_blank">
<ExternalLink className="size-3" />
Re-open authorization page
</a>
<FlowFooter left={<DocsLink href={flow.start.auth_url}>Re-open authorization page</DocsLink>}>
<CancelBtn />
<Button disabled={!flow.code.trim()} onClick={() => void submitOnboardingCode(ctx)}>
Continue
</Button>
<div className="flex gap-2">
<Button onClick={cancelOnboardingFlow} variant="ghost">
Cancel
</Button>
<Button disabled={!flow.code.trim()} onClick={() => void submitOnboardingCode(ctx)}>
Continue
</Button>
</div>
</div>
</div>
</FlowFooter>
</Step>
)
}
if (flow.status === 'external_pending') {
return (
<div className="grid gap-4">
<div>
<h3 className="text-sm font-semibold">Sign in with {title}</h3>
<p className="mt-1 text-sm text-muted-foreground">
{title} signs in through its own CLI. Run this command in a terminal, then come back and pick "I've signed
in":
</p>
</div>
<div className="flex items-center justify-between gap-3 rounded-2xl border border-border bg-secondary/30 px-4 py-3">
<code className="font-mono text-sm">{flow.provider.cli_command}</code>
<Button onClick={() => void copyExternalCommand()} size="sm" variant="outline">
{flow.copied ? <Check className="size-4" /> : 'Copy'}
<Step title={`Sign in with ${title}`}>
<p className="text-sm text-muted-foreground">
{title} signs in through its own CLI. Run this command in a terminal, then come back and pick "I've signed
in":
</p>
<CodeBlock copied={flow.copied} onCopy={() => void copyExternalCommand()} text={flow.provider.cli_command} />
<FlowFooter left={flow.provider.docs_url ? <DocsLink href={flow.provider.docs_url}>{title} docs</DocsLink> : null}>
<CancelBtn />
<Button onClick={() => void recheckExternalSignin(ctx)}>
<Check className="size-4" />
I've signed in
</Button>
</div>
<div className="flex items-center justify-between gap-3">
{flow.provider.docs_url ? (
<Button asChild size="xs" variant="ghost">
<a href={flow.provider.docs_url} rel="noreferrer" target="_blank">
<ExternalLink className="size-3" />
{title} docs
</a>
</Button>
) : (
<span />
)}
<div className="flex gap-2">
<Button onClick={cancelOnboardingFlow} variant="ghost">
Cancel
</Button>
<Button onClick={() => void recheckExternalSignin(ctx)}>
<Check className="size-4" />
I've signed in
</Button>
</div>
</div>
</div>
</FlowFooter>
</Step>
)
}
@ -460,44 +403,82 @@ function FlowPanel({ ctx, flow }: { ctx: OnboardingContext; flow: OnboardingFlow
}
return (
<div className="grid gap-4">
<div>
<h3 className="text-sm font-semibold">Sign in with {title}</h3>
<p className="mt-1 text-sm text-muted-foreground">
We opened {title} in your browser. Enter this code there:
</p>
</div>
<div className="flex items-center justify-between gap-3 rounded-2xl border border-border bg-secondary/30 px-4 py-3">
<code className="font-mono text-2xl tracking-[0.4em]">{flow.start.user_code}</code>
<Button onClick={() => void copyDeviceCode()} size="sm" variant="outline">
{flow.copied ? <Check className="size-4" /> : 'Copy'}
</Button>
</div>
<div className="flex items-center justify-between gap-3">
<Button asChild size="xs" variant="ghost">
<a href={flow.start.verification_url} rel="noreferrer" target="_blank">
<ExternalLink className="size-3" />
Re-open verification page
</a>
</Button>
<div className="flex items-center gap-3">
<div className="flex items-center gap-2 text-xs text-muted-foreground">
<Loader2 className="size-3 animate-spin" />
Waiting for you to authorize...
</div>
<Button onClick={cancelOnboardingFlow} size="sm" variant="ghost">
Cancel
</Button>
</div>
</div>
</div>
<Step title={`Sign in with ${title}`}>
<p className="text-sm text-muted-foreground">We opened {title} in your browser. Enter this code there:</p>
<CodeBlock copied={flow.copied} large onCopy={() => void copyDeviceCode()} text={flow.start.user_code} />
<FlowFooter left={<DocsLink href={flow.start.verification_url}>Re-open verification page</DocsLink>}>
<span className="flex items-center gap-2 text-xs text-muted-foreground">
<Loader2 className="size-3 animate-spin" />
Waiting for you to authorize...
</span>
<CancelBtn size="sm" />
</FlowFooter>
</Step>
)
}
function Status({ children, icon }: { children: React.ReactNode; icon: React.ReactNode }) {
function Step({ children, title }: { children: React.ReactNode; title: string }) {
return (
<div className="flex items-center gap-3 rounded-2xl bg-muted/30 px-4 py-6 text-sm text-muted-foreground">
{icon}
<div className="grid gap-4">
<h3 className="text-sm font-semibold">{title}</h3>
{children}
</div>
)
}
function CodeBlock({
copied,
large,
onCopy,
text
}: {
copied: boolean
large?: boolean
onCopy: () => void
text: string
}) {
return (
<div className="flex items-center justify-between gap-3 rounded-2xl border border-border bg-secondary/30 px-4 py-3">
<code className={cn('font-mono', large ? 'text-2xl tracking-[0.4em]' : 'text-sm')}>{text}</code>
<Button onClick={onCopy} size="sm" variant="outline">
{copied ? <Check className="size-4" /> : 'Copy'}
</Button>
</div>
)
}
function FlowFooter({ children, left }: { children: React.ReactNode; left?: React.ReactNode }) {
return (
<div className="flex items-center justify-between gap-3">
<div className="min-w-0">{left}</div>
<div className="flex items-center gap-3">{children}</div>
</div>
)
}
function CancelBtn({ size = 'default' }: { size?: 'default' | 'sm' }) {
return (
<Button onClick={cancelOnboardingFlow} size={size} variant="ghost">
Cancel
</Button>
)
}
function DocsLink({ children, href }: { children: React.ReactNode; href: string }) {
return (
<Button asChild size="xs" variant="ghost">
<a href={href} rel="noreferrer" target="_blank">
<ExternalLink className="size-3" />
{children}
</a>
</Button>
)
}
function Status({ children }: { children: React.ReactNode }) {
return (
<div className="flex items-center gap-3 rounded-2xl bg-muted/30 px-4 py-6 text-sm text-muted-foreground">
<Loader2 className="size-4 animate-spin" />
{children}
</div>
)

View file

@ -11,13 +11,16 @@ import {
import { notify, notifyError } from '@/store/notifications'
import type { OAuthProvider, OAuthStartResponse } from '@/types/hermes'
type PkceStart = Extract<OAuthStartResponse, { flow: 'pkce' }>
type DeviceStart = Extract<OAuthStartResponse, { flow: 'device_code' }>
export type OnboardingMode = 'apikey' | 'oauth'
export type OnboardingFlow =
| { status: 'idle' }
| { provider: OAuthProvider; status: 'starting' }
| { code: string; provider: OAuthProvider; start: Extract<OAuthStartResponse, { flow: 'pkce' }>; status: 'awaiting_user' }
| { copied: boolean; provider: OAuthProvider; start: Extract<OAuthStartResponse, { flow: 'device_code' }>; status: 'polling' }
| { code: string; provider: OAuthProvider; start: PkceStart; status: 'awaiting_user' }
| { copied: boolean; provider: OAuthProvider; start: DeviceStart; status: 'polling' }
| { provider: OAuthProvider; start: OAuthStartResponse; status: 'submitting' }
| { copied: boolean; provider: OAuthProvider; status: 'external_pending' }
| { provider: OAuthProvider; status: 'success' }
@ -32,6 +35,11 @@ export interface DesktopOnboardingState {
requested: boolean
}
export interface OnboardingContext {
onCompleted?: () => void
requestGateway: <T = unknown>(method: string, params?: Record<string, unknown>) => Promise<T>
}
const INITIAL: DesktopOnboardingState = {
configured: true,
flow: { status: 'idle' },
@ -41,32 +49,21 @@ const INITIAL: DesktopOnboardingState = {
requested: false
}
export const $desktopOnboarding = atom<DesktopOnboardingState>(INITIAL)
export interface OnboardingContext {
onCompleted?: () => void
requestGateway: <T = unknown>(method: string, params?: Record<string, unknown>) => Promise<T>
}
const POLL_MS = 2000
const COPY_FLASH_MS = 1500
const BUSY: ReadonlySet<OnboardingFlow['status']> = new Set([
'starting',
'awaiting_user',
'polling',
'submitting',
'external_pending'
])
export const $desktopOnboarding = atom<DesktopOnboardingState>(INITIAL)
let pollTimer: number | null = null
function patch(update: Partial<DesktopOnboardingState>) {
$desktopOnboarding.set({ ...$desktopOnboarding.get(), ...update })
}
const errMessage = (e: unknown) => (e instanceof Error ? e.message : String(e))
function setFlow(flow: OnboardingFlow) {
patch({ flow })
}
const patch = (update: Partial<DesktopOnboardingState>) =>
$desktopOnboarding.set({ ...$desktopOnboarding.get(), ...update })
const setFlow = (flow: OnboardingFlow) => patch({ flow })
const sessionIdFor = (flow: OnboardingFlow) => ('start' in flow && flow.start ? flow.start.session_id : undefined)
function clearPoll() {
if (pollTimer !== null) {
@ -75,23 +72,40 @@ function clearPoll() {
}
}
function errMessage(error: unknown) {
return error instanceof Error ? error.message : String(error)
async function safeReq<T>(ctx: OnboardingContext, method: string, fallback: T): Promise<T> {
try {
return await ctx.requestGateway<T>(method)
} catch {
return fallback
}
}
async function checkRuntime(ctx: OnboardingContext) {
const [status, runtime] = await Promise.all([
ctx.requestGateway<{ provider_configured?: boolean }>('setup.status').catch(
() => ({}) as { provider_configured?: boolean }
),
ctx
.requestGateway<{ error?: string; ok?: boolean }>('setup.runtime_check')
.catch(() => ({ ok: false }) as { error?: string; ok?: boolean })
safeReq<{ provider_configured?: boolean }>(ctx, 'setup.status', {}),
safeReq<{ error?: string; ok?: boolean }>(ctx, 'setup.runtime_check', { ok: false })
])
return runtime.ok !== undefined ? Boolean(runtime.ok) : Boolean(status.provider_configured)
}
function notifyReady(provider: string) {
notify({ kind: 'success', title: 'Hermes is ready', message: `${provider} connected.` })
}
async function reloadAndConnect(ctx: OnboardingContext, providerName: string, onFail: () => void) {
await ctx.requestGateway('reload.env').catch(() => undefined)
const ok = await checkRuntime(ctx)
if (ok) {
notifyReady(providerName)
completeDesktopOnboarding()
ctx.onCompleted?.()
} else {
onFail()
}
}
export function requestDesktopOnboarding(reason = 'No inference provider is configured.') {
patch({ reason, requested: true })
}
@ -106,9 +120,7 @@ export function setOnboardingMode(mode: OnboardingMode) {
}
export async function refreshOnboarding(ctx: OnboardingContext) {
const ok = await checkRuntime(ctx)
if (ok) {
if (await checkRuntime(ctx)) {
completeDesktopOnboarding()
ctx.onCompleted?.()
@ -123,10 +135,7 @@ export async function refreshOnboarding(ctx: OnboardingContext) {
try {
const { providers } = await listOAuthProviders()
patch({
providers,
mode: providers.length > 0 ? 'oauth' : 'apikey'
})
patch({ providers, mode: providers.length > 0 ? 'oauth' : 'apikey' })
} catch {
patch({ providers: [], mode: 'apikey' })
}
@ -134,34 +143,15 @@ export async function refreshOnboarding(ctx: OnboardingContext) {
return false
}
async function finalize(provider: OAuthProvider, ctx: OnboardingContext) {
clearPoll()
setFlow({ status: 'success', provider })
notify({ kind: 'success', title: 'Hermes is ready', message: `${provider.name} connected.` })
await ctx.requestGateway('reload.env').catch(() => undefined)
const ok = await checkRuntime(ctx)
if (ok) {
completeDesktopOnboarding()
ctx.onCompleted?.()
} else {
setFlow({
status: 'error',
provider,
message: 'Connected, but Hermes still cannot resolve a usable provider.'
})
}
}
export async function startProviderOAuth(provider: OAuthProvider, ctx: OnboardingContext) {
clearPoll()
if (provider.flow === 'external') {
clearPoll()
setFlow({ status: 'external_pending', provider, copied: false })
return
}
clearPoll()
setFlow({ status: 'starting', provider })
try {
@ -181,24 +171,23 @@ export async function startProviderOAuth(provider: OAuthProvider, ctx: Onboardin
}
}
async function pollDevice(
provider: OAuthProvider,
start: Extract<OAuthStartResponse, { flow: 'device_code' }>,
ctx: OnboardingContext
) {
async function pollDevice(provider: OAuthProvider, start: DeviceStart, ctx: OnboardingContext) {
try {
const resp = await pollOAuthSession(provider.id, start.session_id)
const { error_message, status } = await pollOAuthSession(provider.id, start.session_id)
if (resp.status === 'approved') {
await finalize(provider, ctx)
} else if (resp.status !== 'pending') {
if (status === 'approved') {
clearPoll()
setFlow({
status: 'error',
provider,
start,
message: resp.error_message || `Sign-in ${resp.status}.`
})
setFlow({ status: 'success', provider })
await reloadAndConnect(ctx, provider.name, () =>
setFlow({
status: 'error',
provider,
message: 'Connected, but Hermes still cannot resolve a usable provider.'
})
)
} else if (status !== 'pending') {
clearPoll()
setFlow({ status: 'error', provider, start, message: error_message || `Sign-in ${status}.` })
}
} catch (error) {
clearPoll()
@ -228,7 +217,14 @@ export async function submitOnboardingCode(ctx: OnboardingContext) {
const resp = await submitOAuthCode(provider.id, start.session_id, code.trim())
if (resp.ok && resp.status === 'approved') {
await finalize(provider, ctx)
setFlow({ status: 'success', provider })
await reloadAndConnect(ctx, provider.name, () =>
setFlow({
status: 'error',
provider,
message: 'Connected, but Hermes still cannot resolve a usable provider.'
})
)
} else {
setFlow({ status: 'error', provider, start, message: resp.message || 'Token exchange failed.' })
}
@ -238,15 +234,8 @@ export async function submitOnboardingCode(ctx: OnboardingContext) {
}
export function cancelOnboardingFlow() {
const { flow } = $desktopOnboarding.get()
clearPoll()
const sessionId =
flow.status === 'awaiting_user' || flow.status === 'polling' || flow.status === 'submitting'
? flow.start?.session_id
: flow.status === 'error'
? flow.start?.session_id
: undefined
const sessionId = sessionIdFor($desktopOnboarding.get().flow)
if (sessionId) {
cancelOAuthSession(sessionId).catch(() => undefined)
@ -275,7 +264,7 @@ async function copyAndFlash(text: string, predicate: (flow: OnboardingFlow) => b
if (predicate(current) && 'copied' in current) {
setFlow({ ...current, copied: false })
}
}, 1500)
}, COPY_FLASH_MS)
}
export async function copyDeviceCode() {
@ -285,10 +274,8 @@ export async function copyDeviceCode() {
return
}
await copyAndFlash(
flow.start.user_code,
f => f.status === 'polling' && f.start.session_id === flow.start.session_id
)
const sid = flow.start.session_id
await copyAndFlash(flow.start.user_code, f => f.status === 'polling' && f.start.session_id === sid)
}
export async function copyExternalCommand() {
@ -298,7 +285,8 @@ export async function copyExternalCommand() {
return
}
await copyAndFlash(flow.provider.cli_command, f => f.status === 'external_pending' && f.provider.id === flow.provider.id)
const id = flow.provider.id
await copyAndFlash(flow.provider.cli_command, f => f.status === 'external_pending' && f.provider.id === id)
}
export async function recheckExternalSignin(ctx: OnboardingContext) {
@ -308,19 +296,14 @@ export async function recheckExternalSignin(ctx: OnboardingContext) {
return
}
const ok = await checkRuntime(ctx)
if (ok) {
notify({ kind: 'success', title: 'Hermes is ready', message: `${flow.provider.name} connected.` })
completeDesktopOnboarding()
ctx.onCompleted?.()
} else {
const { provider } = flow
await reloadAndConnect(ctx, provider.name, () =>
setFlow({
status: 'error',
provider: flow.provider,
message: `Hermes still cannot reach ${flow.provider.name}. Run \`${flow.provider.cli_command}\` in a terminal first.`
provider,
message: `Hermes still cannot reach ${provider.name}. Run \`${provider.cli_command}\` in a terminal first.`
})
}
)
}
export async function saveOnboardingApiKey(envKey: string, value: string, label: string, ctx: OnboardingContext) {
@ -332,25 +315,19 @@ export async function saveOnboardingApiKey(envKey: string, value: string, label:
try {
await setEnvVar(envKey, trimmed)
await ctx.requestGateway('reload.env').catch(() => undefined)
const ok = await checkRuntime(ctx)
let stillFailing = false
await reloadAndConnect(ctx, label, () => {
stillFailing = true
})
if (ok) {
notify({ kind: 'success', title: 'Hermes is ready', message: `${label} connected.` })
completeDesktopOnboarding()
ctx.onCompleted?.()
return { ok: true }
if (stillFailing) {
return { ok: false, message: `Saved, but Hermes still cannot reach ${label}. Double-check the value.` }
}
return { ok: false, message: `Saved, but Hermes still cannot reach ${label}. Double-check the value.` }
return { ok: true }
} catch (error) {
notifyError(error, `Could not save ${label}`)
return { ok: false, message: errMessage(error) }
}
}
export function isOnboardingBusy(flow: OnboardingFlow) {
return BUSY.has(flow.status)
}