From 111544d544d6cf6efed9875e116f2daeb76a1211 Mon Sep 17 00:00:00 2001 From: Kshitij Kapoor Date: Fri, 10 Jul 2026 00:41:03 +0530 Subject: [PATCH] test(codex-picker): raise max_models so count invariant survives catalog growth Adding the 6 gpt-5.6 slugs to DEFAULT_CODEX_MODELS grew the curated codex catalog to 11, above the test's max_models=10 cap. That truncated the picker list to 10 while total_models reported 11, breaking the total_models == len(models) assertion. The cap was an implicit change-detector on catalog size; raise it to 100 so the list is never truncated and the count-consistency invariant stays meaningful as new gpt-5.x slugs land. --- tests/hermes_cli/test_codex_cli_model_picker.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/hermes_cli/test_codex_cli_model_picker.py b/tests/hermes_cli/test_codex_cli_model_picker.py index 3968437a856..b0dd1c6435a 100644 --- a/tests/hermes_cli/test_codex_cli_model_picker.py +++ b/tests/hermes_cli/test_codex_cli_model_picker.py @@ -95,7 +95,10 @@ def test_codex_picker_uses_live_codex_catalog(hermes_auth_only_env, tmp_path, mo providers = list_authenticated_providers( current_provider="openai-codex", - max_models=10, + # High cap so the curated catalog is never truncated — the assertion + # below checks count consistency, which only holds when max_models + # exceeds the catalog size (it grows as new gpt-5.x slugs land). + max_models=100, ) codex = next(p for p in providers if p["slug"] == "openai-codex")