mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-06-08 08:11:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

refactor(gateway): generalize topic recovery via adapter hook

Browse source 
Replace the runner-introspection trick in #32998 with an explicit
`set_topic_recovery_fn` setter on `BasePlatformAdapter`. The gateway
runner installs it once at adapter init; the adapter calls
`_apply_topic_recovery(event)` before any session keying.

Also apply the hook in `BasePlatformAdapter.handle_message` so the
running-agent guard and pending-message queue key off the recovered
thread_id too — not just the text-batch coalescence.

Net change vs #32998 alone: -2 files of indirection (no
`_message_handler.__self__` peek, no separate `_normalize_text_batch_source`),
+1 generic mechanism (other adapters can install their own hook later).
This commit is contained in:
teknium1 2026-05-28 20:49:53 -07:00 • committed by Teknium
parent 5407d25599
commit 100536134c
4 changed files with 71 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

48
tests/gateway/test_telegram_text_batching.py
View file

@ -126,16 +126,9 @@ class TestTextBatching:
async def test_dm_topic_batching_recovers_thread_before_keying(self):
"""DM-topic text batches should use the recovered topic lane."""
adapter = _make_adapter()
class _Runner:
def _recover_telegram_topic_thread_id(self, source):
return "222" if str(source.thread_id or "") == "1" else None
async def _handle_message(self, _event):
return None
runner = _Runner()
adapter._message_handler = runner._handle_message
adapter.set_topic_recovery_fn(
lambda source: "222" if str(source.thread_id or "") == "1" else None
)
event = MessageEvent(
text="hello from DM topic",
message_type=MessageType.TEXT,
@ -150,29 +143,20 @@ class TestTextBatching:
adapter._enqueue_text_event(event)
recovered_key = build_session_key(
SimpleNamespace(
platform=Platform.TELEGRAM,
chat_id="12345",
chat_type="dm",
thread_id="222",
),
group_sessions_per_user=True,
thread_sessions_per_user=False,
)
stale_key = build_session_key(
SimpleNamespace(
platform=Platform.TELEGRAM,
chat_id="12345",
chat_type="dm",
thread_id="1",
),
group_sessions_per_user=True,
thread_sessions_per_user=False,
)
def _key(thread_id: str) -> str:
return build_session_key(
SimpleNamespace(
platform=Platform.TELEGRAM,
chat_id="12345",
chat_type="dm",
thread_id=thread_id,
),
group_sessions_per_user=True,
thread_sessions_per_user=False,
)
assert recovered_key in adapter._pending_text_batches
assert stale_key not in adapter._pending_text_batches
assert _key("222") in adapter._pending_text_batches
assert _key("1") not in adapter._pending_text_batches
assert event.source.thread_id == "222"
await asyncio.sleep(0.2)