From 0f741cef285aec8014cbf5e00c5df950bc2a4d8a Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Mon, 22 Jun 2026 12:31:25 -0700 Subject: [PATCH] fix(tests): update cua install tests for cross-platform support f-trycua's #50855 test file predated the cross-platform PR (#50552) and reintroduced two stale tests asserting Linux is unsupported (test_*_non_macos_*, patching platform.system="Linux" and expecting a no-op/warn). Linux + Windows are supported now, so install proceeds on those platforms. Restore main's cross-platform-correct versions: test_*_on_unsupported_platform_* using FreeBSD as the genuinely unsupported case. --- tests/hermes_cli/test_install_cua_driver.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/hermes_cli/test_install_cua_driver.py b/tests/hermes_cli/test_install_cua_driver.py index e05dd42627c..d12eacca264 100644 --- a/tests/hermes_cli/test_install_cua_driver.py +++ b/tests/hermes_cli/test_install_cua_driver.py @@ -25,19 +25,19 @@ from unittest.mock import patch class TestInstallCuaDriverUpgrade: - def test_upgrade_on_non_macos_is_silent_noop(self): + def test_upgrade_on_unsupported_platform_is_silent_noop(self): from hermes_cli import tools_config with patch.object(tools_config, "_print_warning") as warn, \ - patch("platform.system", return_value="Linux"): + patch("platform.system", return_value="FreeBSD"): assert tools_config.install_cua_driver(upgrade=True) is False warn.assert_not_called() - def test_non_upgrade_on_non_macos_warns(self): + def test_non_upgrade_on_unsupported_platform_warns(self): from hermes_cli import tools_config with patch.object(tools_config, "_print_warning") as warn, \ - patch("platform.system", return_value="Linux"): + patch("platform.system", return_value="FreeBSD"): assert tools_config.install_cua_driver(upgrade=False) is False warn.assert_called()