From 07443ea21a30d7a4a341d3ad01600cf77de3279c Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Tue, 14 Jul 2026 22:31:19 -0700 Subject: [PATCH] test(codex): pin codex_backend issuer in summary-only reasoning sibling test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The #64434 change makes unrecognized issuers trust response.status='completed' for reasoning-only turns, so this sibling test (which exercised the old default-path behavior) now pins the Codex backend explicitly — the surface where reasoning-only still means 'still thinking'. --- tests/agent/test_codex_responses_adapter.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/agent/test_codex_responses_adapter.py b/tests/agent/test_codex_responses_adapter.py index 72b8787e02e4..4e8a25a661ba 100644 --- a/tests/agent/test_codex_responses_adapter.py +++ b/tests/agent/test_codex_responses_adapter.py @@ -51,6 +51,12 @@ def test_normalize_codex_response_drops_transient_rs_tmp_reasoning_items(): def test_normalize_codex_response_treats_summary_only_reasoning_as_incomplete(): + """Summary-only reasoning keeps the continuation path for Codex backends. + + Since #64434, an unrecognized issuer with ``response.status="completed"`` + trusts the provider and returns ``stop`` — so this test pins the Codex + backend explicitly, where reasoning-only still means "still thinking". + """ response = SimpleNamespace( status="completed", output=[ @@ -63,7 +69,9 @@ def test_normalize_codex_response_treats_summary_only_reasoning_as_incomplete(): ], ) - assistant_message, finish_reason = _normalize_codex_response(response) + assistant_message, finish_reason = _normalize_codex_response( + response, issuer_kind="codex_backend" + ) assert finish_reason == "incomplete" assert assistant_message.content == ""