mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-18 04:41:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(memory): pin session_start + session_id on background review fork

Browse source 
Belt-and-suspenders complement to the cached-system-prompt inheritance:
pin session_start and session_id to the parent's so any code path that
re-renders parts of the system prompt (compression, plugin hooks)
still produces byte-identical output. The cached-prompt assignment
already short-circuits the normal rebuild path, but these pins
guarantee parity even if a future code path bypasses the cache.

Idea from simpolism's reference PR #25427 for #25322.

Co-Authored-By: simpolism <32201324+simpolism@users.noreply.github.com>
This commit is contained in:
teknium1 2026-05-13 22:04:49 -07:00 • committed by Teknium
parent 95d074cdb2
commit 07349ce4df
2 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
run_agent.py
View file

@ -4316,6 +4316,15 @@ class AIAgent:
# measured impact (~26% end-to-end cost reduction on
# Sonnet 4.5).
review_agent._cached_system_prompt = self._cached_system_prompt
# Defensive: pin session_start + session_id to the
# parent's so any code path that re-renders parts of
# the system prompt (compression, plugin hooks) still
# produces byte-identical output. The cached-prompt
# assignment above already short-circuits the normal
# rebuild path, but these pins guarantee parity even
# if a future code path bypasses the cache.
review_agent.session_start = self.session_start
review_agent.session_id = self.session_id
from model_tools import get_tool_definitions
from hermes_cli.plugins import (