test(desktop): contract test — every cron helper is profile-scoped

Salvaged from #59888 by @isfttr: the profileScoped() fix itself landed
via #67493 (salvaged from the earlier #49948), but this PR contributed a
contract test locking all 9 cron helpers to the active gateway profile —
omitted when none is set (single-profile users unaffected), attached when
one is active. Keeps the multi-profile/remote cron routing from silently
regressing.
This commit is contained in:
isfttr 2026-07-19 09:59:15 -07:00 committed by Teknium
parent 65b73eb1e9
commit 0385e15544
2 changed files with 60 additions and 0 deletions

View file

@ -0,0 +1,59 @@
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import {
createCronJob,
deleteCronJob,
getCronJob,
getCronJobRuns,
getCronJobs,
pauseCronJob,
resumeCronJob,
setApiRequestProfile,
triggerCronJob,
updateCronJob
} from './hermes'
// Contract: every cron helper must carry the active gateway profile, so a
// multi-profile / remote user's cron list, runs, and mutations hit the backend
// they're actually on — not the primary/default. Without it, selecting a remote
// profile still showed the local primary's jobs (the "remote cron jobs don't
// show up" bug), the counterpart to the backend-action-helper fix in
// hermes-profile-scope.test.ts.
describe('cron helpers are profile-scoped', () => {
const api = vi.fn(async (_req: { path: string; profile?: string }) => ({}) as never)
beforeEach(() => {
;(window as { hermesDesktop?: unknown }).hermesDesktop = { api }
api.mockClear()
})
afterEach(() => {
setApiRequestProfile(null)
delete (window as { hermesDesktop?: unknown }).hermesDesktop
})
const lastProfile = () => api.mock.calls.at(-1)?.[0].profile
it('omits profile when none is active (single-profile users unaffected)', () => {
void getCronJobs()
expect(lastProfile()).toBeUndefined()
})
it('forwards the active profile to every cron helper', () => {
setApiRequestProfile('coder')
void getCronJobs()
void getCronJob('job-1')
void getCronJobRuns('job-1')
void createCronJob({ name: 'nightly', prompt: 'run', schedule: '0 3 * * *' } as never)
void updateCronJob('job-1', { enabled: false } as never)
void pauseCronJob('job-1')
void resumeCronJob('job-1')
void triggerCronJob('job-1')
void deleteCronJob('job-1')
for (const call of api.mock.calls) {
expect(call[0].profile).toBe('coder')
}
})
})

View file

@ -0,0 +1 @@
isfttr