From 6893faf47299ff22ae96b886bb320878c9f662c8 Mon Sep 17 00:00:00 2001 From: Brooklyn Nicholson Date: Sun, 26 Jul 2026 04:25:16 -0500 Subject: [PATCH 1/5] feat(desktop): style inline links as tinted chips Content links read as a small primary-tinted chip instead of an underline, dropping the trailing external-link arrow. The tint is currentColor-relative, so one class carries text and fill in the same hue across every theme, and `box-decoration-break: clone` gives a wrapped link a chip per line fragment. --- .../assistant-ui/directive-text.tsx | 2 +- .../components/assistant-ui/markdown-text.tsx | 11 +++----- .../src/components/chat/compact-markdown.tsx | 11 +++----- .../chat/generated-image-result.tsx | 2 +- apps/desktop/src/lib/external-link.tsx | 4 +-- apps/desktop/src/styles.css | 26 +++++++++++++++++++ 6 files changed, 37 insertions(+), 19 deletions(-) diff --git a/apps/desktop/src/components/assistant-ui/directive-text.tsx b/apps/desktop/src/components/assistant-ui/directive-text.tsx index c9a45f2d3f76..317489a96f82 100644 --- a/apps/desktop/src/components/assistant-ui/directive-text.tsx +++ b/apps/desktop/src/components/assistant-ui/directive-text.tsx @@ -510,7 +510,7 @@ export const SessionRefLink: FC<{ return ( { event.preventDefault() diff --git a/apps/desktop/src/components/assistant-ui/markdown-text.tsx b/apps/desktop/src/components/assistant-ui/markdown-text.tsx index 7684a4c4240c..f641890ffd40 100644 --- a/apps/desktop/src/components/assistant-ui/markdown-text.tsx +++ b/apps/desktop/src/components/assistant-ui/markdown-text.tsx @@ -100,7 +100,7 @@ function OpenMediaButton({ kind, path }: { kind: 'audio' | 'video'; path: string return ( + {open && ( +
+          {technicalTrace(args, result)}
+        
+ )} + + ) +} + interface ToolStatusCopy { statusDone: string statusError: string @@ -616,19 +655,7 @@ function ToolEntry({ part }: ToolEntryProps) { )} ))} - {toolViewMode === 'technical' && !(isFileEdit && view.inlineDiff) && ( -
-              {technicalTrace(part.args, part.result)}
-            
- )} - {toolViewMode === 'technical' && isFileEdit && view.inlineDiff && ( -
- Tool payload -
-                {technicalTrace(part.args, part.result)}
-              
-
- )} + {toolViewMode === 'technical' && } )} From 9947a6065baca2fd0a7926acb79729818cc5957c Mon Sep 17 00:00:00 2001 From: Brooklyn Nicholson Date: Sun, 26 Jul 2026 05:00:53 -0500 Subject: [PATCH 5/5] fix(desktop): align external-link icon tests with default-off --- apps/desktop/src/lib/external-link.test.tsx | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/apps/desktop/src/lib/external-link.test.tsx b/apps/desktop/src/lib/external-link.test.tsx index 772105648017..582b061e8ea6 100644 --- a/apps/desktop/src/lib/external-link.test.tsx +++ b/apps/desktop/src/lib/external-link.test.tsx @@ -112,11 +112,24 @@ describe('external link helpers', () => { expect(openExternal).toHaveBeenCalledWith('https://example.com/path/to/resource') }) - it('shows a trailing external-link icon', () => { + it('hides the trailing external-link icon by default', () => { installDesktopBridge() render(Example link) + const link = screen.getByRole('link', { name: 'Example link' }) + expect(link.querySelector('svg')).toBeNull() + }) + + it('shows a trailing external-link icon when opted in', () => { + installDesktopBridge() + + render( + + Example link + , + ) + const link = screen.getByRole('link', { name: 'Example link' }) expect(link.querySelector('svg')).toBeTruthy() })