mirrors/hermes-agent
1
0
Fork 0
mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-06-07 08:02:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

fix(tui): handle timeout/error subagent statuses in /agents (#26687)

Browse source 
Accept delegation timeout/error statuses in the TUI subagent model, normalize unknown status strings defensively, and harden /agents overlay rendering/sorting so unknown statuses cannot crash glyph/color lookup. Add regression tests for live event normalization and disk snapshot replay.
This commit is contained in:
brooklyn! 2026-05-15 20:19:02 -05:00 • committed by GitHub
parent 566d8f0d75
commit 006937f7d0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 173 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

55
ui-tui/src/__tests__/createGatewayEventHandler.test.ts
View file

@ -737,6 +737,61 @@ describe('createGatewayEventHandler', () => {
expect(getTurnState().activity).toMatchObject([{ text: 'boom', tone: 'error' }])
})
it('accepts timeout/error subagent terminal statuses and ignores stale live events', () => {
const appended: Msg[] = []
const onEvent = createGatewayEventHandler(buildCtx(appended))
onEvent({
payload: { goal: 'timeout child', subagent_id: 'sa-timeout', task_index: 0 },
type: 'subagent.start'
} as any)
onEvent({
payload: { goal: 'timeout child', status: 'timeout', subagent_id: 'sa-timeout', task_index: 0 },
type: 'subagent.complete'
} as any)
expect(getTurnState().subagents.find(s => s.id === 'sa-timeout')?.status).toBe('timeout')
// Late start/spawn updates must not clobber terminal timeout/error states.
onEvent({
payload: { goal: 'timeout child', subagent_id: 'sa-timeout', task_index: 0 },
type: 'subagent.start'
} as any)
onEvent({
payload: { goal: 'timeout child', subagent_id: 'sa-timeout', task_index: 0 },
type: 'subagent.spawn_requested'
} as any)
expect(getTurnState().subagents.find(s => s.id === 'sa-timeout')?.status).toBe('timeout')
onEvent({
payload: { goal: 'error child', subagent_id: 'sa-error', task_index: 1 },
type: 'subagent.start'
} as any)
onEvent({
payload: { goal: 'error child', status: 'error', subagent_id: 'sa-error', task_index: 1 },
type: 'subagent.complete'
} as any)
expect(getTurnState().subagents.find(s => s.id === 'sa-error')?.status).toBe('error')
})
it('normalizes unknown subagent.complete statuses to completed', () => {
const appended: Msg[] = []
const onEvent = createGatewayEventHandler(buildCtx(appended))
onEvent({
payload: { goal: 'weird child', subagent_id: 'sa-weird', task_index: 2 },
type: 'subagent.start'
} as any)
onEvent({
payload: { goal: 'weird child', status: 'mystery_status', subagent_id: 'sa-weird', task_index: 2 },
type: 'subagent.complete'
} as any)
expect(getTurnState().subagents.find(s => s.id === 'sa-weird')?.status).toBe('completed')
})
it('drops stale reasoning/tool/todos events after ctrl-c until the next message starts', () => {
// Repro for the discord report: ctrl-c interrupts, but late reasoning/tool
// events from the still-winding-down agent loop kept populating the UI for